Skip to content

[improve][broker] Make internalGetStats to async - #15348

Merged
Technoboy- merged 3 commits into
apache:masterfrom
nodece:async_get_stats
May 11, 2022
Merged

[improve][broker] Make internalGetStats to async#15348
Technoboy- merged 3 commits into
apache:masterfrom
nodece:async_get_stats

Conversation

@nodece

@nodece nodece commented Apr 27, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Motivation

Avoid using the synchronization method in internalGetStats().

Modifications

  • Use the asynchronous method instead of the synchronization method
  • Remove getStat method from NonPersistentTopics controller, because of the NonPersistentTopics inherits PersistentTopics

Documentation

Need to update docs?

  • no-need-doc

@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Apr 27, 2022
@codelipenghui codelipenghui added this to the 2.11.0 milestone Apr 28, 2022
@nodece
nodece force-pushed the async_get_stats branch 2 times, most recently from 78544c8 to 5f2add6 Compare April 28, 2022 04:23
@nodece
[improve][broker] Make internalGetStats to async
f85b039 
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@nodece
nodece requested a review from codelipenghui April 28, 2022 09:10
@nodece

nodece commented Apr 28, 2022

Copy link
Copy Markdown
Member Author

/pulsarbot rerun-failure-checks

1 similar comment
@nodece

nodece commented Apr 29, 2022

Copy link
Copy Markdown
Member Author

/pulsarbot rerun-failure-checks

@Technoboy- Technoboy- added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/broker labels May 4, 2022
@nodece
Add test
e8d7d6e 
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@nodece
nodece requested a review from codelipenghui May 7, 2022 08:39
@nodece
Fix CI
43c955c 
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@nodece

nodece commented May 9, 2022

Copy link
Copy Markdown
Member Author

/pulsarbot rerun-failure-checks

@Technoboy-
Technoboy- merged commit 1fda9b2 into apache:master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes
@codelipenghui codelipenghui codelipenghui approved these changes
@congbobo184 congbobo184 Awaiting requested review from congbobo184
@gaoran10 gaoran10 Awaiting requested review from gaoran10
@Jason918 Jason918 Awaiting requested review from Jason918
@mattisonchao mattisonchao Awaiting requested review from mattisonchao

Assignees

@nodece nodece

Labels

area/broker doc-not-needed Your PR changes do not impact docs type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages

Projects

None yet

Milestone

2.11.0

Development

Successfully merging this pull request may close these issues.

3 participants

@nodece @Technoboy- @codelipenghui