Skip to content

[WIP] Commit for test ci, ignore this pr - #15385

Closed
horizonzy wants to merge 3 commits into
apache:masterfrom
horizonzy:test-10117
Closed

[WIP] Commit for test ci, ignore this pr#15385
horizonzy wants to merge 3 commits into
apache:masterfrom
horizonzy:test-10117

Conversation

@horizonzy

Copy link
Copy Markdown
Member

Commit for test ci, needn't view.

@github-actions

Copy link
Copy Markdown

@horizonzy:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@nicoloboschi nicoloboschi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you explain more why you split the test?
it doesn't show up correctly in the CI results? can you provide an example?

@horizonzy

Copy link
Copy Markdown
Member Author

could you explain more why you split the test? it doesn't show up correctly in the CI results? can you provide an example?

Not mint it, I'm trying to find the flaky test root case, split it just for find.

@horizonzy horizonzy changed the title Commit for test ci, needn't view. Commit for test ci, ignore this pr Apr 29, 2022
@nicoloboschi

Copy link
Copy Markdown
Contributor

@horizonzy ok, I suggest you to set the pull as draft, add "WIP" in the title or create it in your fork to not cause confustion

@horizonzy

Copy link
Copy Markdown
Member Author

@horizonzy ok, I suggest you to set the pull as draft, add "WIP" in the title or create it in your fork to not cause confustion

I try it at my fork and upstream both... It will be faster for test.

@horizonzy horizonzy changed the title Commit for test ci, ignore this pr [WIP] Commit for test ci, ignore this pr Apr 29, 2022
@lhotari

lhotari commented Apr 29, 2022

Copy link
Copy Markdown
Member

@horizonzy If you want to test the CI or modify it, please consider opening PRs to your own fork of apache/pulsar since we have very limited resources in apache/pulsar.
In your own fork, you can run GitHub Actions workflows independently and your builds won't cause the build queue to grow in apache/pulsar.

@horizonzy

Copy link
Copy Markdown
Member Author

@horizonzy If you want to test the CI or modify it, please consider opening PRs to your own fork of apache/pulsar since we have very limited resources in apache/pulsar. In your own fork, you can run GitHub Actions workflows independently and your builds won't cause the build queue to grow in apache/pulsar.

fine, after ci done at this time, I won't do it again.

@lhotari

lhotari commented Apr 29, 2022

Copy link
Copy Markdown
Member

fine, after ci done at this time, I won't do it again.

@horizonzy +1. There are some instructions in https://lists.apache.org/thread/1ofdbd9j1hhj4c0rw3o7vv8y6rbsxrp0 about using "Personal CI".

@lhotari

lhotari commented Apr 29, 2022

Copy link
Copy Markdown
Member

@horizonzy The additional benefit of the "Personal CI" is that you get ssh access to the build VMs when the build is running. That is handled by this logic in the pulsar-ci.yaml GitHub Actions workflow file:

- name: Setup ssh access to build runner VM
# ssh access is enabled for builds in own forks
if: ${{ github.repository != 'apache/pulsar' && needs.changed_files_job.outputs.docs_only != 'true' }}
uses: ./.github/actions/ssh-access
with:
limit-access-to-actor: true

and inline composite action implementation: https://github.com/apache/pulsar/blob/master/.github/actions/ssh-access/action.yml

The ssh acccess is secured with the ssh key registered in Github. for example, your public keys are https://github.com/horizonzy.keys . You will first have to register a ssh public key in GitHub for that to work.

@horizonzy

Copy link
Copy Markdown
Member Author

@horizonzy The additional benefit of the "Personal CI" is that you get ssh access to the build VMs when the build is running. That is handled by this logic in the pulsar-ci.yaml GitHub Actions workflow file:

Thanks your guide

@lhotari
lhotari marked this pull request as draft April 29, 2022 09:18
@horizonzy horizonzy closed this Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants