Skip to content

[improve][doc]single source of truth for functions CLI and add a table for yml configs - #15389

Merged
Anonymitaet merged 6 commits into
apache:masterfrom
momo-jun:functions-config
Jun 9, 2022
Merged

[improve][doc]single source of truth for functions CLI and add a table for yml configs#15389
Anonymitaet merged 6 commits into
apache:masterfrom
momo-jun:functions-config

Conversation

@momo-jun

@momo-jun momo-jun commented Apr 29, 2022

Copy link
Copy Markdown
Contributor

Motivation

As one of the actions to improve the doc set of Pulsar Functions, the motivation is to provide Pulsar users with a more user-centric, accurate, and comprehensive information experience.

Modifications

  1. Replace the duplicate and outdated CLI information with the link of Pulsar admin CLI docs.
  2. Add tables to outline the required fields and arguments to configure a function via a .yaml file.
  3. Add examples.

The preview looks good.
image
image

Documentation

  • doc
    (Your PR contains doc changes)

@github-actions

Copy link
Copy Markdown

@momo-jun:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions

Copy link
Copy Markdown

@momo-jun:Thanks for providing doc info!

@github-actions github-actions Bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Apr 29, 2022
@momo-jun momo-jun changed the title [enhance][doc] single source of truth for functions CLI and add a table for yml configs [improve][doc] single source of truth for functions CLI and add a table for yml configs Apr 29, 2022
@momo-jun

momo-jun commented May 5, 2022

Copy link
Copy Markdown
Contributor Author

Hi @freeznet @nlu90 can you pls review this doc PR? Thanks.
//cc @Anonymitaet

@momo-jun momo-jun changed the title [improve][doc] single source of truth for functions CLI and add a table for yml configs [improve][doc][do-not-merge] single source of truth for functions CLI and add a table for yml configs May 12, 2022
Comment thread site2/docs/functions-cli.md Outdated

You can configure a function by using a predefined a .yaml file. The following table outlines the required fields and arguments.

| Field Name | Nested Field | Type | Related Command Argument | Description |

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to put the Nested Field to the last column

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nested fields have been moved to sub-tables for a clear view. PTAL.

Comment thread site2/docs/functions-cli.md Outdated
Comment thread site2/docs/functions-cli.md Outdated
Comment thread site2/docs/functions-cli.md Outdated
Comment thread site2/docs/functions-cli.md Outdated
Comment thread site2/docs/functions-cli.md Outdated
Comment thread site2/docs/functions-cli.md Outdated
Comment thread site2/docs/functions-cli.md Outdated
Comment thread site2/docs/functions-cli.md Outdated
Comment thread site2/docs/functions-cli.md Outdated
@Anonymitaet Anonymitaet added this to the 2.11.0 milestone May 31, 2022
@momo-jun

momo-jun commented Jun 6, 2022

Copy link
Copy Markdown
Contributor Author

Ping @Anonymitaet for review.

@Anonymitaet

Copy link
Copy Markdown
Member

/pulsarbot run-failure-checks

@Anonymitaet
Anonymitaet merged commit c4fcaa6 into apache:master Jun 9, 2022
@momo-jun momo-jun changed the title [improve][doc][do-not-merge] single source of truth for functions CLI and add a table for yml configs [improve][doc]single source of truth for functions CLI and add a table for yml configs Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants