[fix][broker] Fix to avoid TopicStatsImpl NPE even if producerName is null#15502
Merged
Technoboy- merged 2 commits intoMay 14, 2022
Merged
Conversation
Contributor
|
Why the produceName is null? |
Contributor
Get it from the issue comment. |
Contributor
|
I think the root cause is here : We should set producerName for the newStats
|
Contributor
Author
Yes. I think so too.
I think we can't set producerName in this section, because old client's partitioned producer can have different producerName between internal producers. #12401 |
Contributor
Ok, make sense. |
Technoboy-
approved these changes
May 12, 2022
codelipenghui
approved these changes
May 14, 2022
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 23, 2022
… null (apache#15502) (cherry picked from commit 7bdfa3a) (cherry picked from commit d23e251)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15471
Motivation
Please see #15471 .
Modifications
supportsPartialProducer=falsesupportsPartialProducer=true, because stats are aggregated by producerNameVerifying this change
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
no-need-docThis PR is one of the fixing issues.