[fix][broker] Added newline to end of standalone.conf - #15591
Merged
Conversation
…v-with-prefix.py to append properties
merlimat
approved these changes
May 13, 2022
merlimat
left a comment
Contributor
There was a problem hiding this comment.
👍
In any case, the script was also already fixed to handle it:
pulsar/docker/pulsar/scripts/apply-config-from-env.py
Lines 78 to 80 in 17db729
nodece
approved these changes
May 13, 2022
Contributor
Author
that is missing from |
Contributor
Oh, gotcha. Do you mind creating a PR to fix it there too? :) |
Contributor
Author
No probs, created -> #15596 |
Technoboy-
approved these changes
May 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Without a new line at the end of the file, running
apply-config-from-env-with-prefix.pywith a new property appends directly to the file so you end up with something likemanagedLedgerMaxUnackedRangesToPersistInZooKeeper=-1myotherproperty=valueand startup failsModifications
Added a new line at end of file
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
Documentation
Need to update docs?
no-need-docsimple conf file change