Skip to content

[enh] Issue 15455: Pulsar Admin: create subscripion with Properties (PIP-105) (#15503) - #15681

Merged
eolivelli merged 1 commit into
apache:branch-2.10from
eolivelli:impl/create-subscription-properties-pip105-branch-2.10
May 23, 2022
Merged

[enh] Issue 15455: Pulsar Admin: create subscripion with Properties (PIP-105) (#15503)#15681
eolivelli merged 1 commit into
apache:branch-2.10from
eolivelli:impl/create-subscription-properties-pip105-branch-2.10

Conversation

@eolivelli

Copy link
Copy Markdown
Contributor

This is the port of #15488 to branch-2.10
cherry picked from commit e2fa189

I am porting to 2.10 because PIP-105 is missing this feature in order to be used.
There is a little API addition, but it is 100% backward compatible.

@github-actions

Copy link
Copy Markdown

@eolivelli:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@eolivelli eolivelli added the doc-not-needed Your PR changes do not impact docs label May 20, 2022
@github-actions

Copy link
Copy Markdown

@eolivelli:Thanks for providing doc info!

@nicoloboschi nicoloboschi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eolivelli
eolivelli merged commit c7f9ffd into apache:branch-2.10 May 23, 2022
eolivelli added a commit to datastax/pulsar that referenced this pull request May 23, 2022
@eolivelli
eolivelli deleted the impl/create-subscription-properties-pip105-branch-2.10 branch May 23, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants