[fix][broker]Fast return if ack cumulative illegal - #15695
Merged
Conversation
Contributor
Author
|
/pulsarbot run-failure-checks |
codelipenghui
left a comment
Contributor
There was a problem hiding this comment.
The change looks good. Could you please help add a test?
For the changes of line:382, it should be a bug fix and the behavior changed?
Before this change, if cumulative ack happened on a Shared subscription, the ack will take effect, but after this change, the ack will not take effect if the request with only one ack.
Contributor
Author
|
Add UT, PTAL @codelipenghui |
AnonHxy
force-pushed
the
fix_ack_cumulative
branch
from
May 22, 2022 18:48
a6891ed to
e94f1fd
Compare
Contributor
Author
|
/pulsarbot run-failure-checks |
2 similar comments
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
Author
|
/pulsarbot run-failure-checks |
codelipenghui
requested review from
BewareMyPower,
Technoboy-,
gaoran10 and
mattisonchao
June 1, 2022 04:09
codelipenghui
approved these changes
Jun 2, 2022
hangc0276
approved these changes
Jun 2, 2022
coderzc
approved these changes
Jun 2, 2022
shibd
approved these changes
Jun 2, 2022
mattisonchao
approved these changes
Jun 2, 2022
codelipenghui
pushed a commit
to codelipenghui/incubator-pulsar
that referenced
this pull request
Jun 7, 2022
(cherry picked from commit 02dca31)
codelipenghui
pushed a commit
that referenced
this pull request
Jun 10, 2022
(cherry picked from commit 02dca31)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
CommandAckModifications
ack.getMessageIdsCount() != 1orSubscription.isIndividualAckMode(subType)Verifying this change
org.apache.pulsar.broker.service.MessageCumulativeAckTestDocumentation
no-need-doc