[improve][kinesis-sink] Add unit test for Kinesis sink JsonConverter - #15848
Merged
Conversation
Contributor
eolivelli
approved these changes
May 31, 2022
Contributor
Author
cbornet
marked this pull request as draft
May 31, 2022 08:49
cbornet
force-pushed
the
kinesis-jsonconverter
branch
from
May 31, 2022 08:54
aef9aaa to
2ff92d6
Compare
cbornet
changed the title
cbornet
force-pushed
the
kinesis-jsonconverter
branch
from
May 31, 2022 14:33
2ff92d6 to
06b473a
Compare
cbornet
marked this pull request as ready for review
May 31, 2022 14:34
nicoloboschi
approved these changes
May 31, 2022
Contributor
Author
|
/pulsarbot rerun-failure-checks |
shibd
reviewed
Jun 1, 2022
| @Test | ||
| public void testAvroToJson() throws IOException { | ||
| Schema avroArraySchema = SchemaBuilder.array().items(SchemaBuilder.builder().stringType()); | ||
| Schema schema = SchemaBuilder.record("record").fields() |
Member
There was a problem hiding this comment.
Suggestion adds Logical type test. Remind, JsonNode will default to the scientific and technical method when acquiring big data types. refer to: #15687
Contributor
Author
There was a problem hiding this comment.
This PR is mainly to align with Elastic Search JsonConverter tests. Maybe we could improve with Logical types in a follow-up PR for both ?
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 3, 2022
…pache#15848) (cherry picked from commit 8c21c00)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Improves test coverage
Modifications
Added a test
Verifying this change
This change added tests and can be verified as follows:
Run JsonConverterTests
Does this pull request potentially affect one of the following parts:
no
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-neededfix
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)