[fix][client] Fix conversion of TimestampMillisConversion has no effect when Jsr310Conversion enabled - #15863
Merged
Merged
Conversation
coderzc
changed the title
coderzc
changed the title
nicoloboschi
approved these changes
May 31, 2022
nicoloboschi
left a comment
nicoloboschi
left a comment
Contributor
There was a problem hiding this comment.
good work!
can you change the title explaining the issue ?
improve avro conversion order of registration seems an improvement and it doesn't talk about the timestamp problem
coderzc
changed the title
TimestampMillisConversion has no effect when Jsr310Conversion enabled
coderzc
changed the title
TimestampMillisConversion has no effect when Jsr310Conversion enabledTimestampMillisConversion has no effect when Jsr310Conversion enabled
Member
Author
ok, I changed the title |
shibd
approved these changes
Jun 1, 2022
codelipenghui
approved these changes
Jun 1, 2022
codelipenghui
added
release/2.9.3
release/2.8.4
release/2.10.1
type/bug
Contributor
|
It would be great to see this fix also applied to at least 2.9.x and 2.8.x branches. Is 2.7.x no longer supported? |
hangc0276
pushed a commit
that referenced
this pull request
Jun 7, 2022
### Motivation Fixes #15858 The conversion that is registered first is a higher priority than the registered later, so `TimestampMillisConversion` should not be registered after `TimestampMicrosConversion`. ### Modifications Improve `avro` conversion order of registration. (cherry picked from commit 311fdb5)
codelipenghui
pushed a commit
to codelipenghui/incubator-pulsar
that referenced
this pull request
Jun 7, 2022
### Motivation Fixes apache#15858 The conversion that is registered first is a higher priority than the registered later, so `TimestampMillisConversion` should not be registered after `TimestampMicrosConversion`. ### Modifications Improve `avro` conversion order of registration. (cherry picked from commit 311fdb5)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 7, 2022
### Motivation Fixes apache#15858 The conversion that is registered first is a higher priority than the registered later, so `TimestampMillisConversion` should not be registered after `TimestampMicrosConversion`. ### Modifications Improve `avro` conversion order of registration. (cherry picked from commit 311fdb5) (cherry picked from commit 7377a59)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 7, 2022
### Motivation Fixes apache#15858 The conversion that is registered first is a higher priority than the registered later, so `TimestampMillisConversion` should not be registered after `TimestampMicrosConversion`. ### Modifications Improve `avro` conversion order of registration. (cherry picked from commit 311fdb5) (cherry picked from commit 784c9c8)
codelipenghui
pushed a commit
that referenced
this pull request
Jun 10, 2022
### Motivation Fixes #15858 The conversion that is registered first is a higher priority than the registered later, so `TimestampMillisConversion` should not be registered after `TimestampMicrosConversion`. ### Modifications Improve `avro` conversion order of registration. (cherry picked from commit 311fdb5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #15858
The conversion that is registered first is a higher priority than the registered later, so
TimestampMillisConversionshould not be registered afterTimestampMicrosConversion.Modifications
Improve
avroconversion order of registration.Verifying this change
This change added tests and can be verified
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)