[feature][admin] Support to get topic properties. - #15944
Merged
codelipenghui merged 5 commits intoJun 8, 2022
Merged
Conversation
Technoboy-
changed the title
codelipenghui
approved these changes
Jun 6, 2022
codelipenghui
added
release/2.10.1
type/feature
mattisonchao
approved these changes
Jun 7, 2022
mattisonchao
left a comment
mattisonchao
left a comment
Member
There was a problem hiding this comment.
LGTM, Left some small suggestions.
codelipenghui
pushed a commit
that referenced
this pull request
Jun 12, 2022
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 13, 2022
As apache#12818 has supported creating topics with metadata, this patch is adding a `get` API to support getting topic properties. (cherry picked from commit 1ebe4ee) (cherry picked from commit 6648f99)
| throw new RestException(Status.NOT_FOUND, | ||
| getTopicNotFoundErrorMessage(topicName.toString())); | ||
| } | ||
| return ((PersistentTopic) opt.get()).getManagedLedger().getProperties(); |
Contributor
There was a problem hiding this comment.
https://github.com/apache/pulsar/pull/12818/files introduced ManagedLedgerConfig.properties
https://github.com/apache/pulsar/pull/12818/files#diff-c917471bc697b80ff5e8eb5de212597c527e756ea49694c7fbbabacbf2b9752cR76.
However, we are returning ManagedLedgerImpl.propertiesMap here.
Why do we have two properties in two different places?
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As #12818 has supported creating topics with metadata, this patch is adding a
getAPI to support getting topic properties.Documentation
doc-not-needed(Please explain why)