Revert "[fix][broker] Reject auto create partitioned topic when topic name contains -partition- (#14920) - #16066
Merged
Conversation
mattisonchao
requested review from
Jason918,
RobertIndie,
Technoboy- and
codelipenghui
June 15, 2022 01:24
Member
Author
|
Because there have some unclear things need to discuss. I will put the list link here when start discussing. |
Member
Author
|
Also, I have to push a new pull request to add a test that can cover the DLQ of |
shibd
approved these changes
Jun 15, 2022
codelipenghui
approved these changes
Jun 15, 2022
Technoboy-
approved these changes
Jun 16, 2022
Closed
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request reverts commit #14920
Motivation
Revert PR #14920 because it may affect the DLQ when the user enables
auto-creationand the creative type ispartitioned.Modifications
-partition-#14920.Verifying this change
Documentation
doc-not-needed