Skip to content

Changed Docker Maven plugin from Spotify to fabric8 - #16099

Closed
merlimat wants to merge 1 commit into
apache:masterfrom
merlimat:maven-docker
Closed

Changed Docker Maven plugin from Spotify to fabric8#16099
merlimat wants to merge 1 commit into
apache:masterfrom
merlimat:maven-docker

Conversation

@merlimat

@merlimat merlimat commented Jun 16, 2022

Copy link
Copy Markdown
Contributor

Motivation

The maven plugin com.spotify:dockerfile-maven-plugin that we are using to build Docker images has been discontinued and not supported for quite some time. There are also things that don't work anymore with this plugin, like for example building on M1 Mac with an ARM based JVM.

The suggested replacement is io.fabric8:docker-maven-plugin (https://dmp.fabric8.io) which is actively mantained.

  • doc-not-needed

@merlimat merlimat added this to the 2.11.0 milestone Jun 16, 2022
@merlimat merlimat self-assigned this Jun 16, 2022
@github-actions

Copy link
Copy Markdown

@merlimat Please provide a correct documentation label for your PR.
Instructions see Pulsar Documentation Label Guide.

@merlimat merlimat added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Jun 16, 2022

@nicoloboschi nicoloboschi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaeljmarshall michaeljmarshall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattisonchao

Copy link
Copy Markdown
Member

Re-open this PR to rerun the test.

@mattisonchao

Copy link
Copy Markdown
Member

@merlimat Could you please check the failed test?

@eolivelli eolivelli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eolivelli

Copy link
Copy Markdown
Contributor

CI is failing while building the docker image. maybe we have to fine tune this patch

2022-07-29T02:07:11.1326799Z [INFO] ------------------------------------------------------------------------
2022-07-29T02:07:11.1442724Z [ERROR] Failed to execute goal on project pulsar-all-docker-image: Could not resolve dependencies for project org.apache.pulsar:pulsar-all-docker-image:pom:2.11.0-SNAPSHOT: Could not find artifact org.apache.pulsar:pulsar-docker-image:jar:docker-info:2.11.0-SNAPSHOT in apache.snapshots (https://repository.apache.org/snapshots) -> [Help 1]
2022-07-29T02:07:11.1444564Z [ERROR]

cc @lhotari @merlimat

@codelipenghui codelipenghui removed this from the 2.11.0 milestone Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants