[fix][java-client] Make DeadLetterPolicy deserializable - #16513
Merged
Conversation
Contributor
|
Why not only add |
Member
Author
Because |
gaoran10
requested changes
Jul 11, 2022
| DeadLetterPolicy policy = | ||
| DeadLetterPolicy.builder().deadLetterTopic("a").retryLetterTopic("a").initialSubscriptionName("a") | ||
| .maxRedeliverCount(1).build(); | ||
| consumerBuilder.deadLetterPolicy(policy); |
Contributor
There was a problem hiding this comment.
Do you want to add policy in the config map?
Member
Author
There was a problem hiding this comment.
I want test DeadLetterPolicy deserialization
codelipenghui
approved these changes
Jul 12, 2022
codelipenghui
added
type/bug
codelipenghui
changed the title
liudezhi2098
approved these changes
Jul 13, 2022
gaozhangmin
pushed a commit
to gaozhangmin/pulsar
that referenced
this pull request
Jul 14, 2022
michaeljmarshall
approved these changes
Jul 14, 2022
Member
|
Thanks @coderzc! |
wuxuanqicn
pushed a commit
to wuxuanqicn/pulsar
that referenced
this pull request
Jul 14, 2022
codelipenghui
pushed a commit
that referenced
this pull request
Jul 15, 2022
(cherry picked from commit abe4350)
mattisonchao
pushed a commit
that referenced
this pull request
Jul 15, 2022
(cherry picked from commit abe4350)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16487
Motivation
DeadLetterPolicy can't deserialization, the root cause is DeadLetterPolicy without a No-argument constructor.
Modifications
Add
@NoArgsConstructorand@AllArgsConstructorannotates for DeadLetterPolicy.Verifying this change
This change is already covered by existing tests, such as
testDeadLetterPolicyDeserialize.(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)