[fix][java-client] Skip TopicListWatcher creation when lookup url scheme is HTTP - #16576
Merged
Merged
Conversation
Motivation TopicListWatcher's can not work when the lookup url scheme is HTTP. Changes - Not creating a TopicListWatcher when HTTP url is specified - Create test to avoid future regressions in this area
merlimat
approved these changes
Jul 13, 2022
Technoboy-
added
type/enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TopicListWatchers need a ClientCnx to communicate to a broker, but they have no topic to discover the owner. So they rely on the lookup URL. When the scheme is HTTP, no ClientCnx can be created with it.
Modifications
Verifying this change
This change added a test
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-not-neededThis is a bug fix. The whole feature needs to be documented as stated on [feat][broker] PIP-145: Notifications for faster topic discovery #16062