Skip to content

[fix][flaky-test] fix cumulative ack test after abort redeliver message - #16592

Merged
congbobo184 merged 1 commit into
apache:masterfrom
congbobo184:congbobo184_fix_flaky_test_txnCumulativeAckTest
Jul 14, 2022
Merged

[fix][flaky-test] fix cumulative ack test after abort redeliver message#16592
congbobo184 merged 1 commit into
apache:masterfrom
congbobo184:congbobo184_fix_flaky_test_txnCumulativeAckTest

Conversation

@congbobo184

@congbobo184 congbobo184 commented Jul 14, 2022

Copy link
Copy Markdown
Contributor

Motivation

since #14371 merged, when the client abort txn with cumulative ack, We need to the redeliver message manually

Modifications

change test when transaction abort with cumulative ack, redeliver message manually

Verifying this change

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduces a new feature? (yes)

  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

  • If a feature is not applicable for documentation, explain why?

  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

  • doc-not-needed

@congbobo184 congbobo184 added type/bug The PR fixed a bug or issue reported a bug area/transaction type/flaky-tests doc-not-needed Your PR changes do not impact docs labels Jul 14, 2022
@congbobo184 congbobo184 added this to the 2.11.0 milestone Jul 14, 2022
@congbobo184 congbobo184 self-assigned this Jul 14, 2022

@liangyepianzhou liangyepianzhou left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@congbobo184
congbobo184 merged commit 86295be into apache:master Jul 14, 2022
@congbobo184 congbobo184 changed the title [fix][flaky-test] fix cumulative ack test after abort redeliver messa… [fix][flaky-test] fix cumulative ack test after abort redeliver message Jul 15, 2022
@congbobo184

Copy link
Copy Markdown
Contributor Author

#16589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/transaction doc-not-needed Your PR changes do not impact docs type/bug The PR fixed a bug or issue reported a bug type/flaky-tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants