[improve][connector] add reader config to pulsar-io-debezium and pulsar-io-kafka-connect-adaptor - #16675
Merged
codelipenghui merged 5 commits intoJul 25, 2022
Conversation
freeznet
added
type/enhancement
github-actions
Bot
added
the
doc-required
codelipenghui
left a comment
codelipenghui
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just left a minor comment.
freeznet
force-pushed
the
freeznet/add-sub-name-for-debezium-reader
branch
from
July 21, 2022 01:30
ed2e9d4 to
1470168
Compare
Contributor
Author
|
/pulsarbot run-failure-checks |
freeznet
force-pushed
the
freeznet/add-sub-name-for-debezium-reader
branch
from
July 22, 2022 03:09
1470168 to
84cee00
Compare
Contributor
Author
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Jul 25, 2022
nlu90
approved these changes
Jul 25, 2022
codelipenghui
added
cherry-picked/branch-2.9
Contributor
|
Hi @freeznet, do you have any updates on the required doc? |
5 tasks
Anonymitaet
added
doc-complete
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 16, 2022
…ulsar-io-kafka-connect-adaptor` (apache#16675) (cherry picked from commit 9c19976) (cherry picked from commit d923c84)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16674
Motivation
Allow user customize the reader configs in pulsar-io-debezium and pulsar-io-kafka-connect-adaptor.
Modifications
offset.storage.reader.configtoPulsarKafkaWorkerConfigpulsar.reader.configtoPulsarDatabaseHistoryVerifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)