[improve][txn] PIP-160: Transaction log store enables the batch feature - #16685
Merged
Conversation
codelipenghui
added
type/enhancement
codelipenghui
changed the title
codelipenghui
changed the title
congbobo184
requested review from
codelipenghui,
congbobo184,
gaoran10 and
liangyepianzhou
July 20, 2022 01:45
congbobo184
reviewed
Jul 20, 2022
Technoboy-
reviewed
Jul 21, 2022
| MLTransactionLogImpl mlTransactionLog = new MLTransactionLogImpl(TransactionCoordinatorID.get(0), | ||
| pulsar.getManagedLedgerFactory(), managedLedgerConfig, txnLogBufferedWriterConfig, | ||
| scheduledExecutorService); | ||
| mlTransactionLog.initialize().join(); |
Contributor
There was a problem hiding this comment.
It's better to add a timeout on the method or here.
Contributor
Author
There was a problem hiding this comment.
Good idea. Already fixed
congbobo184
reviewed
Jul 21, 2022
|
|
||
| public class MLTransactionMetadataStoreTest extends MockedBookKeeperTestCase { | ||
|
|
||
| private ScheduledExecutorService scheduledExecutorService = Executors.newScheduledThreadPool(3); |
Contributor
There was a problem hiding this comment.
- It's better to add a single test that adds batch transaction log and then can open a new cursor for the transaction log managedLedger and read the batch log. then the TransactionCoordinator can recover successfully
- add a test for the log delete
Contributor
Author
There was a problem hiding this comment.
Already fixed, it is MLTransactionLogImplTest
codelipenghui
left a comment
codelipenghui
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, just left some minor comments.
Contributor
Author
|
/pulsarbot run-failure-checks |
1 similar comment
Contributor
Author
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Jul 22, 2022
congbobo184
approved these changes
Jul 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master Issue: #15370
Motivation
see #15370
Modifications
I will complete proposal #15370 with these pull requests( current pull request is the step-3 ):
TxnLogBufferedWriterDocumentation
doc-requireddoc-not-neededdocdoc-complete