[improve][broker]add NamespacePolicies and AntiAffinity check before unload in checkNamespaceBundleSplit - #16780
Merged
Conversation
Nicklee007
force-pushed
the
add-namespace-polices-and-anti-affinity-check-in-checkNamespaceBundleSplit
branch
3 times, most recently
from
August 30, 2022 02:33
5d6daa7 to
5c7e481
Compare
Contributor
Author
|
/pulsarbot run-failure-checks |
Nicklee007
force-pushed
the
add-namespace-polices-and-anti-affinity-check-in-checkNamespaceBundleSplit
branch
from
September 5, 2022 08:24
5c7e481 to
be77de2
Compare
Nicklee007
force-pushed
the
add-namespace-polices-and-anti-affinity-check-in-checkNamespaceBundleSplit
branch
from
September 21, 2022 09:14
be77de2 to
d098466
Compare
Nicklee007
force-pushed
the
add-namespace-polices-and-anti-affinity-check-in-checkNamespaceBundleSplit
branch
from
September 30, 2022 07:28
d098466 to
8859c06
Compare
|
The pr had no activity for 30 days, mark with Stale label. |
codelipenghui
requested review from
Technoboy-,
gaoran10,
hangc0276,
hezhangjian,
mattisonchao,
michaeljmarshall and
zymap
October 31, 2022 04:07
Nicklee007
force-pushed
the
add-namespace-polices-and-anti-affinity-check-in-checkNamespaceBundleSplit
branch
from
December 7, 2022 09:35
8859c06 to
8c17ec2
Compare
Nicklee007
force-pushed
the
add-namespace-polices-and-anti-affinity-check-in-checkNamespaceBundleSplit
branch
from
December 7, 2022 09:46
1f56dc6 to
8c17ec2
Compare
Codecov Report
@@ Coverage Diff @@
## master #16780 +/- ##
============================================
- Coverage 44.79% 35.84% -8.95%
+ Complexity 10026 6745 -3281
============================================
Files 703 623 -80
Lines 68808 59072 -9736
Branches 7375 6147 -1228
============================================
- Hits 30822 21174 -9648
- Misses 34378 35102 +724
+ Partials 3608 2796 -812
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Contributor
Author
|
/pulsarbot rerun-failure-checks |
Contributor
Author
|
@codelipenghui @Technoboy- Could you help review this PR , better to check if has another broker satisfy |
|
The pr had no activity for 30 days, mark with Stale label. |
…mespaceBundleSplit
Nicklee007
force-pushed
the
add-namespace-polices-and-anti-affinity-check-in-checkNamespaceBundleSplit
branch
from
January 10, 2023 06:20
8c17ec2 to
7a6a1f8
Compare
Contributor
Author
|
/pulsarbot rerun-failure-checks |
Technoboy-
approved these changes
Jan 11, 2023
Contributor
Author
|
/pulsarbot rerun-failure-checks |
gaozhangmin
approved these changes
Jan 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add
NamespacePoliciesandAntiAffinitycheck before unload bundle whencheckNamespaceBundleSplit.When unload the bundle after split, It's better to guarantee there are at least one another broker can load those bundle which satisfy the NamespacePolicies and AntiAffinity. Otherwise the bundle may not load successfully and cause the client reconnect frequently.
Modifications
checkNamespaceBundleSplit.Documentation
doc-not-neededMatching PR in forked repository
PR in forked repository:Nicklee007#2