[fix][broker][branch-2.8] Fix potential to add duplicated consumer#16826
Merged
BewareMyPower merged 1 commit intoJul 28, 2022
Merged
Conversation
3 tasks
Contributor
Author
|
@BewareMyPower Could you take a look? |
Contributor
Author
|
/pulsarbot rerun-failure-checks |
Contributor
Author
|
/pulsarbot rerun-failure-checks |
Contributor
|
We can merge this PR once only CI - Unit / unit-tests (pull_request) failed because there is a broken test, see #16813. |
BewareMyPower
approved these changes
Jul 28, 2022
Contributor
Author
|
/pulsarbot rerun-failure-checks |
Contributor
|
Merge this PR first, it looks like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
see #15051
There have conflicts when cherry-picking #15051 PR (branch 2.8 has no
mock staticsupport), so I created a separate PR to fix branch-2.8Modifications
Swap the execution order of duplicate validation and maximum validation
Documentation
doc-requireddoc-not-neededdocdoc-complete