[Java Client] fix PatternTopicsChangedListener blocked when topic removed - #16842
Merged
Technoboy- merged 1 commit intoJul 29, 2022
Merged
Conversation
Technoboy-
added
doc-not-needed
Technoboy-
approved these changes
Jul 28, 2022
codelipenghui
left a comment
codelipenghui
left a comment
Contributor
There was a problem hiding this comment.
@wangjialing218 Could you please help add an unit test to cover this change? The fix looks good to me
Contributor
|
Please rebase to master to have #16812 included. |
wangjialing218
force-pushed
the
branch-fix-regex-listener
branch
from
July 29, 2022 05:48
3fd8f3a to
5359962
Compare
Contributor
Author
|
/pulsarbot run-failure-checks |
Jason918
pushed a commit
that referenced
this pull request
Aug 1, 2022
(cherry picked from commit 2d6b534)
BewareMyPower
pushed a commit
that referenced
this pull request
Aug 1, 2022
(cherry picked from commit 2d6b534)
Gleiphir2769
pushed a commit
to Gleiphir2769/pulsar
that referenced
this pull request
Aug 4, 2022
mattisonchao
pushed a commit
that referenced
this pull request
Aug 4, 2022
(cherry picked from commit 2d6b534)
codelipenghui
pushed a commit
that referenced
this pull request
Aug 8, 2022
(cherry picked from commit 2d6b534)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16839
Modifications
When
PatternTopicsChangedListener#onTopicsRemovedtriggered,removeConsumerAsyncwill throw ClassCastException.When ackTimeoutMillis = 0 (default value),
unAckedMessageTrackeris created withUnAckedMessageTracker.UNACKED_MESSAGE_TRACKER_DISABLEDVerifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
Check the box below or label this PR directly.
doc-not-needed