Fixed stats buffer rotation - #17
Merged
Merged
Conversation
|
CLA is valid! |
Contributor
|
👍 seems have merging issue. |
rdhabalia
approved these changes
Sep 16, 2016
sijie
pushed a commit
to sijie/pulsar
that referenced
this pull request
Mar 4, 2018
Closed
hangc0276
referenced
this pull request
in hangc0276/pulsar
May 26, 2021
This PR is based on [Produce request](streamnative/kop@a09a805), which is in PR #14, please review and merge that first. changes: - change to sn pulsar version, so we could call getter/setter for parent class in `KafkaBrokerService` and `KafkaService`. Or it is not able to do the mock in test framework. - add test framework, - add a simple produce request test, and pass write test.
Technoboy-
referenced
this pull request
in Technoboy-/pulsar
Aug 12, 2021
…tting the resource limit (#17)
Technoboy-
referenced
this pull request
in Technoboy-/pulsar
Aug 12, 2021
…row InterceptException (#17)
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
Access the stats buffer under read lock, since we are not relying on the buffer pool and refcounting anymore.