Skip to content

[fix][flaky-test]ManagedCursorMetricsTest.testCursorReadWriteMetrics #17045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codelipenghui merged 2 commits into from
Aug 12, 2022
Merged

[fix][flaky-test]ManagedCursorMetricsTest.testCursorReadWriteMetrics #17045

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94ee83a
[fix][flaky-test]ManagedCursorMetricsTest.testCursorReadWriteMetrics
poorbarcode Aug 10, 2022
22d6a05
use default timeout
poorbarcode Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/ManagedCursorMetricsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import java.util.ArrayList;
import java.util.List;
import java.util.UUID;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.TimeUnit;
import lombok.Cleanup;
import org.apache.bookkeeper.client.LedgerHandle;
Expand Down Expand Up @@ -197,9 +198,19 @@ public void testManagedCursorMetrics() throws Exception {
admin.topics().delete(topicName, true);
}

private ManagedCursorMXBean getManagedCursorMXBean(String topicName, String subscriptionName)
throws ExecutionException, InterruptedException {
final PersistentSubscription persistentSubscription =
(PersistentSubscription) pulsar.getBrokerService()
.getTopic(topicName, false).get().get().getSubscription(subscriptionName);
final ManagedCursorImpl managedCursor = (ManagedCursorImpl) persistentSubscription.getCursor();
return managedCursor.getStats();
}

@Test
public void testCursorReadWriteMetrics() throws Exception {
final String subName = "read-write";
final String subName1 = "read-write-sub-1";
final String subName2 = "read-write-sub-2";
final String topicName = "persistent://my-namespace/use/my-ns/read-write";
final int messageSize = 10;

Expand All @@ -216,15 +227,15 @@ public void testCursorReadWriteMetrics() throws Exception {
.topic(topicName)
.subscriptionType(SubscriptionType.Shared)
.ackTimeout(1, TimeUnit.SECONDS)
.subscriptionName(subName)
.subscriptionName(subName1)
.subscribe();

@Cleanup
Consumer<byte[]> consumer2 = pulsarClient.newConsumer()
.topic(topicName)
.subscriptionType(SubscriptionType.Shared)
.ackTimeout(1, TimeUnit.SECONDS)
.subscriptionName(subName + "-2")
.subscriptionName(subName2)
.subscribe();

@Cleanup
Expand All @@ -241,6 +252,13 @@ public void testCursorReadWriteMetrics() throws Exception {
consumer2.acknowledge(consumer.receive().getMessageId());
}
}

// Wait for persistent cursor meta.
ManagedCursorMXBean cursorMXBean1 = getManagedCursorMXBean(topicName, subName1);
ManagedCursorMXBean cursorMXBean2 = getManagedCursorMXBean(topicName, subName2);
Awaitility.await().until(() -> cursorMXBean1.getWriteCursorLedgerLogicalSize() > 0);
Awaitility.await().until(() -> cursorMXBean2.getWriteCursorLedgerLogicalSize() > 0);

metricsList = metrics.generate();
Assert.assertEquals(metricsList.size(), 2);
Assert.assertNotEquals(metricsList.get(0).getMetrics().get("brk_ml_cursor_writeLedgerSize"), 0L);
Expand Down