[fix][doc]Fix fileSystemProfilePath wrong default value - #17057
Merged
Conversation
codelipenghui
approved these changes
Aug 11, 2022
codelipenghui
added
the
doc
Technoboy-
pushed a commit
to merlimat/pulsar
that referenced
this pull request
Aug 16, 2022
* [fix][doc]Fix fileSystemProfilePath wrong default value * [fix][doc]update fileSystemProfilePath default value on history version docs
momo-jun
added a commit
to momo-jun/pulsar
that referenced
this pull request
Aug 17, 2022
1 task
momo-jun
added a commit
that referenced
this pull request
Sep 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The configuration item
fileSystemProfilePathinbroker.confhas the wrong default value: For File System Storage,fileSystemProfilePathis the file system profile path; when we use a relative path, the current dir is the pulsar root dir, notconf/dir,so the correct relative path isconf/filesystem_offload_core_site.xmlnot../conf/filesystem_offload_core_site.xml.In addition, this configuration item in our docs also uses the wrong default values.
https://pulsar.apache.org/docs/next/tiered-storage-filesystem#configure-filesystem-offloader-driver
https://pulsar.apache.org/docs/next/tiered-storage-filesystem#step-3-configure-the-filesystem-offloader
https://pulsar.apache.org/docs/next/tiered-storage-filesystem#step-3-configure-the-filesystem-offloader-driver
Modifications
Fix the wrong default va in
broker.conf& docs link.Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)