Skip to content

[monitor][broker][metadata] add metrics for BatchMetadataStore - #17072

Merged
codelipenghui merged 16 commits into
apache:masterfrom
tjiuming:dev/batch_metadata_store_stats
Nov 1, 2022
Merged

[monitor][broker][metadata] add metrics for BatchMetadataStore#17072
codelipenghui merged 16 commits into
apache:masterfrom
tjiuming:dev/batch_metadata_store_stats

Conversation

@tjiuming

@tjiuming tjiuming commented Aug 11, 2022

Copy link
Copy Markdown
Contributor

Motivation

add metrics for batch_metadata_store.
This PR should being merged after #17041 in case of conflicts.

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

Matching PR in forked repository

PR in forked repository: tjiuming#7

@github-actions github-actions Bot added the doc-required Your PR changes impact docs and you will update later. label Aug 11, 2022
@Jason918

Copy link
Copy Markdown
Contributor

TIP: You can covert PR status to draft, if it's not ready for review. :)

@tjiuming tjiuming changed the title [DONT_MERGE][monitoring][broker][metadata_store] add metrics for BatchMetadataStore [draft][monitoring][broker][metadata_store] add metrics for BatchMetadataStore Aug 15, 2022
@tjiuming

Copy link
Copy Markdown
Contributor Author

TIP: You can covert PR status to draft, if it's not ready for review. :)

Thanks~

@Jason918

Copy link
Copy Markdown
Contributor

TIP: You can covert PR status to draft, if it's not ready for review. :)

Thanks~

See this.

image

tjiuming and others added 3 commits August 23, 2022 23:37
# Conflicts:
#	pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java
@tjiuming tjiuming changed the title [draft][monitoring][broker][metadata_store] add metrics for BatchMetadataStore [monitoring][broker][metadata_store] add metrics for BatchMetadataStore Sep 22, 2022
@tjiuming

Copy link
Copy Markdown
Contributor Author

@codelipenghui @asafm PTAL

@asafm asafm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Mainly minor syntax comments aside from one main comment.

@tjiuming tjiuming changed the title [monitoring][broker][metadata_store] add metrics for BatchMetadataStore [monitor][broker][metadata] add metrics for BatchMetadataStore Oct 24, 2022
@tjiuming

Copy link
Copy Markdown
Contributor Author

@asafm I've updated the PR and only keeps pulsar_batch_metadata_store_executor_queue_size, pulsar_batch_metadata_store_queue_wait_time.
and add pulsar_batch_metadata_store_batch_execute_time pulsar_batch_metadata_store_perbatch_ops

@asafm asafm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One small comment left.

@tjiuming

Copy link
Copy Markdown
Contributor Author

@codelipenghui PTAL

@codelipenghui

Copy link
Copy Markdown
Contributor

/pulsarbot run-failure-checks

@codecov-commenter

codecov-commenter commented Nov 1, 2022

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.69%. Comparing base (0866c3a) to head (5127d25).
⚠️ Report is 3399 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #17072      +/-   ##
============================================
- Coverage     38.97%   38.69%   -0.29%     
+ Complexity     8311     8262      -49     
============================================
  Files           683      685       +2     
  Lines         67325    67335      +10     
  Branches       7217     7216       -1     
============================================
- Hits          26239    26053     -186     
- Misses        38079    38281     +202     
+ Partials       3007     3001       -6     
Flag Coverage Δ
unittests 38.69% <ø> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tjiuming

tjiuming commented Nov 1, 2022

Copy link
Copy Markdown
Contributor Author

/pulsarbot run-failure-checks

@tjiuming

tjiuming commented Nov 1, 2022

Copy link
Copy Markdown
Contributor Author

@codelipenghui all the required checks are passed

@codelipenghui
codelipenghui merged commit adae4ae into apache:master Nov 1, 2022
@tjiuming
tjiuming deleted the dev/batch_metadata_store_stats branch November 1, 2022 17:37
@momo-jun

momo-jun commented Nov 2, 2022

Copy link
Copy Markdown
Contributor

@tjiuming did you have a plan to add some information about the new metrics?

@tjiuming

tjiuming commented Nov 2, 2022

Copy link
Copy Markdown
Contributor Author

@tjiuming did you have a plan to add some information about the new metrics?

there are already a PR for the doc, I'll update it soon

@momo-jun momo-jun added doc-complete Your PR changes impact docs and the related docs have been already added. and removed doc-required Your PR changes impact docs and you will update later. labels Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/metadata area/metrics doc-complete Your PR changes impact docs and the related docs have been already added. ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants