[monitor][broker][metadata] add metrics for BatchMetadataStore - #17072
Conversation
|
TIP: You can covert PR status to draft, if it's not ready for review. :) |
Thanks~ |
# Conflicts: # pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/AbstractMetadataStore.java
|
@codelipenghui @asafm PTAL |
asafm
left a comment
There was a problem hiding this comment.
Looks good. Mainly minor syntax comments aside from one main comment.
|
@asafm I've updated the PR and only keeps |
asafm
left a comment
There was a problem hiding this comment.
Looks good. One small comment left.
|
@codelipenghui PTAL |
|
/pulsarbot run-failure-checks |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17072 +/- ##
============================================
- Coverage 38.97% 38.69% -0.29%
+ Complexity 8311 8262 -49
============================================
Files 683 685 +2
Lines 67325 67335 +10
Branches 7217 7216 -1
============================================
- Hits 26239 26053 -186
- Misses 38079 38281 +202
+ Partials 3007 3001 -6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
/pulsarbot run-failure-checks |
|
@codelipenghui all the required checks are passed |
|
@tjiuming did you have a plan to add some information about the new metrics? |
there are already a PR for the doc, I'll update it soon |

Motivation
add metrics for batch_metadata_store.
This PR should being merged after #17041 in case of conflicts.
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)
Matching PR in forked repository
PR in forked repository: tjiuming#7