[fix][broker] Streaming dispatcher stuck after reading the first entry with SHARED subscriptions - #17143
Merged
Merged
Conversation
Technoboy-
approved these changes
Aug 17, 2022
Demogorgon314
approved these changes
Aug 17, 2022
Member
|
Hi @nicoloboschi It looks like it just affects 2.11 and master. Because of the previous branch, we use this PR https://github.com/apache/pulsar/pull/17053/files to cherry-pick. Another concern is why we don't have the test to verify it. :( |
mattisonchao
approved these changes
Aug 17, 2022
mattisonchao
left a comment
Member
There was a problem hiding this comment.
Nice catch, and thanks to you!
Member
|
I will try to move the |
5 tasks
codelipenghui
approved these changes
Aug 17, 2022
Technoboy-
pushed a commit
that referenced
this pull request
Aug 18, 2022
…y with SHARED subscriptions (#17143)
1 task
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: THIS BUG IS NOT IN ANY RELEASED VERSION OF PULSAR.
Motivation
While using a streaming dispatcher (
streamingDispatch=true), the consumer (with a shared subscription) is stuck and it's not able to fully read a topic. That is because after the an entry is read, thereadMoreEntriesmethod is not triggered anymore. This is a regression introduced in #16968Modifications
sendMessagesToConsumersin thePersistentStreamingDispatcherMultipleConsumersin the same way it's used inPersistentDispatcherMultipleConsumersDispatcherDispatchMessagesInSubscriptionThreadalso in the streaming dispatcher - this might be done in another pull but it's a very tiny change - follow up of [enh] Broker - Shared subscription: run filters in a separate (per-subscription) thread (dispatcherDispatchMessagesInSubscriptionThread) #16603The evidence of this bug is that the test a several tests with streaming enabled are failing but since they are in the flaky section, they have been ignored. Now these tests are passing
doc-not-needed