[improvement][tired-storage] fix typo in JCloudBlobStoreProvider - #17205
Closed
yapxue wants to merge 1 commit into
Closed
[improvement][tired-storage] fix typo in JCloudBlobStoreProvider#17205yapxue wants to merge 1 commit into
yapxue wants to merge 1 commit into
Conversation
Member
|
Without this change do you get an error like: |
Member
|
Thank you for your contribution @yapxue! It looks like this was already fixed in #15814. Our project targets fixes to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
There is a typo in JCloudBlobStoreProvider. It can cause 403 when use S3 as long term storage
Modifications
fix typo from ACCESS_KEY_ID to ACCESS_KEY_SECRET
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)