[fix][tool] Using int instead of long in python scripts - #17215
Merged
Conversation
--- *Motivation* In python3.x, long renamed to int, so we should use int instead of long in scripts. *Modification* - rename long to int
zymap
requested review from
Technoboy-,
codelipenghui,
eolivelli,
hangc0276 and
merlimat
August 23, 2022 00:54
hangc0276
approved these changes
Aug 23, 2022
codelipenghui
approved these changes
Aug 23, 2022
Technoboy-
pushed a commit
that referenced
this pull request
Aug 24, 2022
mattisonchao
pushed a commit
that referenced
this pull request
Aug 25, 2022
Jason918
pushed a commit
that referenced
this pull request
Sep 4, 2022
(cherry picked from commit 8286e8c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In python3.x, long renamed to int, so we should use int instead
of long in scripts.
Traceback (most recent call last):
File "bin/pulsar-managed-ledger-admin", line 247, in deleteMLLedgerIdsCommand
deletLedgerIdSet.add(long(id))
NameError: name 'long' is not defined
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)