[fix][client]sendMessage param miss in createOpSendMsg cause CI Build Error - #17297
Closed
Nicklee007 wants to merge 2 commits into
Closed
[fix][client]sendMessage param miss in createOpSendMsg cause CI Build Error#17297Nicklee007 wants to merge 2 commits into
Nicklee007 wants to merge 2 commits into
Conversation
gaozhangmin
approved these changes
Aug 26, 2022
coderzc
approved these changes
Aug 26, 2022
Contributor
|
Why the CI doesn't run failed for now? |
Member
I think because we don‘t mandatorily rebase master before merge PR. |
5 tasks
AnonHxy
approved these changes
Aug 26, 2022
eolivelli
approved these changes
Aug 26, 2022
HQebupt
approved these changes
Aug 26, 2022
Jason918
approved these changes
Aug 26, 2022
lhotari
requested changes
Aug 26, 2022
| ByteBuf encryptedPayload = producer.encryptMessage(messageMetadata, getCompressedBatchMetadataAndPayload()); | ||
| ByteBufPair cmd = producer.sendMessage(producer.producerId, messageMetadata.getSequenceId(), | ||
| 1, messageMetadata, encryptedPayload); | ||
| 1, messages.get(0).getMessageId(), messageMetadata, encryptedPayload); |
Member
There was a problem hiding this comment.
This doesn't look right. Are you sure that this is the correct way to fix this?
Member
Member
There was a problem hiding this comment.
@Jason918 PTAL. isn't it null that should be passed here?
Contributor
There was a problem hiding this comment.
@lhotari Actually, both is fine. ShadowReplicator won't use batch producing.
eolivelli
requested changes
Aug 26, 2022
eolivelli
left a comment
Contributor
There was a problem hiding this comment.
@lhotari is right
closing this PR, thank you @Nicklee007
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix sendMessage param miss in createOpSendMsg which will cause build error.
Build error cause
https://github.com/apache/pulsar/runs/8032271109?check_suite_focus=true
pulsar/pulsar-client/src/main/java/org/apache/pulsar/client/impl/BatchMessageContainerImpl.java
Lines 217 to 223 in c13e669
Modifications
Documentation
doc-not-needed(Please explain why)