Skip to content

[broker][admin] Add cmd to remove topic properties - #17337

Merged
yuruguo merged 3 commits into
apache:masterfrom
yuruguo:add_cmd_to_remove_topic_properties
Sep 1, 2022
Merged

[broker][admin] Add cmd to remove topic properties#17337
yuruguo merged 3 commits into
apache:masterfrom
yuruguo:add_cmd_to_remove_topic_properties

Conversation

@yuruguo

@yuruguo yuruguo commented Aug 29, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Motivation

This pr comes from #17238 (comment) and its purpose is to remove the specified key of properties on the topic.

Modifications

  • Add cmd to remove topic properties

Documentation

  • doc-not-needed

@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Aug 29, 2022
@yuruguo yuruguo self-assigned this Aug 29, 2022
@yuruguo yuruguo added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/admin labels Aug 30, 2022
@yuruguo yuruguo added this to the 2.12.0 milestone Aug 30, 2022
Jason918
Jason918 reviewed Aug 30, 2022
View reviewed changes
Comment thread pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java Outdated
AnonHxy
AnonHxy reviewed Aug 31, 2022
View reviewed changes
Comment thread pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApi2Test.java
Comment thread pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApi2Test.java Outdated
Jason918
Jason918 approved these changes Sep 1, 2022
View reviewed changes

@Jason918 Jason918 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuruguo
yuruguo merged commit 7075a5c into apache:master Sep 1, 2022
nodece pushed a commit to nodece/pulsar that referenced this pull request Sep 8, 2022
@yuruguo @nodece
[broker][admin] Add cmd to remove topic properties (apache#17337)
ab194ba 
* [broker][admin] Add cmd to remove topic properties

* address comment

* address comment
@liangyepianzhou

liangyepianzhou commented Dec 7, 2022 •
edited by yuruguo
Loading

Copy link
Copy Markdown
Contributor

@yuruguo Why does this PR need to release to 2.10.3?

This pr comes from #17238 (comment), and adding release/2.10.3 also refers to it.
However, this is not a correct behavior.
image

liangyepianzhou pushed a commit to streamnative/pulsar-archived that referenced this pull request Mar 1, 2023
@yuruguo @liangyepianzhou
[broker][admin] Add cmd to remove topic properties (apache#17337)
ceaf4ec 
* [broker][admin] Add cmd to remove topic properties

* address comment

* address comment

(cherry picked from commit 7075a5c)
yaalsn pushed a commit to streamnative/pulsar-archived that referenced this pull request Mar 1, 2023
@yuruguo @yaalsn
[broker][admin] Add cmd to remove topic properties (apache#17337)
94579fa 
* [broker][admin] Add cmd to remove topic properties

* address comment

* address comment

(cherry picked from commit 7075a5c)
liangyepianzhou pushed a commit to streamnative/pulsar-archived that referenced this pull request May 10, 2023
@yuruguo @liangyepianzhou
[broker][admin] Add cmd to remove topic properties (apache#17337)
6f8dbc7 
* [broker][admin] Add cmd to remove topic properties

* address comment

* address comment

(cherry picked from commit 7075a5c)
liangyepianzhou added a commit to streamnative/pulsar-archived that referenced this pull request Sep 27, 2023
@liangyepianzhou @AnonHxy
@yuruguo @Flowermin
Cherry pick (#5915)
22b1088 
* [broker][admin]Add api for update topic properties (apache#17238)

(cherry picked from commit b21f728)

* [broker][admin] Add cmd to remove topic properties (apache#17337)

* [broker][admin] Add cmd to remove topic properties

* address comment

* address comment

(cherry picked from commit 7075a5c)
(cherry picked from commit 6f8dbc7)

* [fix][broker] Fix NPE when updating topic's properties (apache#17352)

Co-authored-by: bjhuxiaohua <bjhuxiaohua@foxmail.com>
(cherry picked from commit f1d1158)
(cherry picked from commit 723ad75)

* [fix][broker] Fix NPE when update topic properties.
### Motivation

In Pulsar 2.10, when creating a producer/consumer that auto-creates a topic and then attempts to update its properties, a NullPointerException (NPE) occurs. The reason is that Pulsar 2.10 does not correctly handle the case when the properties are `null`.
### Modifications

Add an NPE check.

(cherry picked from commit 0b02321)

* remove release profile

* import

* Revert "remove release profile"

This reverts commit 6bec650.

---------

Co-authored-by: Xiaoyu Hou <AnonHxyGo@gmail.com>
Co-authored-by: Ruguo Yu <jiang7chengzitc@163.com>
Co-authored-by: Flowermin <48741608+Flowermin@users.noreply.github.com>
liangyepianzhou added a commit to streamnative/pulsar-archived that referenced this pull request Sep 27, 2023
@liangyepianzhou @AnonHxy
@yuruguo @Flowermin
Cherry pick (#5916)
63c656f 
* [broker][admin]Add api for update topic properties (apache#17238)

(cherry picked from commit b21f728)

* [broker][admin] Add cmd to remove topic properties (apache#17337)

* [broker][admin] Add cmd to remove topic properties

* address comment

* address comment

(cherry picked from commit 7075a5c)
(cherry picked from commit 6f8dbc7)

* [fix][broker] Fix NPE when updating topic's properties (apache#17352)

Co-authored-by: bjhuxiaohua <bjhuxiaohua@foxmail.com>
(cherry picked from commit f1d1158)
(cherry picked from commit 723ad75)

* [fix][broker] Fix NPE when update topic properties.
### Motivation

In Pulsar 2.10, when creating a producer/consumer that auto-creates a topic and then attempts to update its properties, a NullPointerException (NPE) occurs. The reason is that Pulsar 2.10 does not correctly handle the case when the properties are `null`.
### Modifications

Add an NPE check.

(cherry picked from commit 0b02321)

* remove release profile

* import

* Revert "remove release profile"

This reverts commit 6bec650.

---------

Co-authored-by: Xiaoyu Hou <AnonHxyGo@gmail.com>
Co-authored-by: Ruguo Yu <jiang7chengzitc@163.com>
Co-authored-by: Flowermin <48741608+Flowermin@users.noreply.github.com>
nodece pushed a commit to nodece/pulsar that referenced this pull request Nov 24, 2023
@yuruguo @nodece
[broker][admin] Add cmd to remove topic properties (apache#17337)
09d445c 
* [broker][admin] Add cmd to remove topic properties

* address comment

* address comment

(cherry picked from commit 7075a5c)
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
@nodece nodece mentioned this pull request Nov 24, 2023
Merged
nodece added a commit to ascentstream/pulsar that referenced this pull request Nov 27, 2023
@nodece @AnonHxy
@yuruguo @Flowermin
[feat][broker] Update and remove topic properties (#4)
09f4094 
* [broker][admin]Add api for update topic properties (apache#17238)

(cherry picked from commit b21f728)
Signed-off-by: Zixuan Liu <nodeces@gmail.com>

* [broker][admin] Add cmd to remove topic properties (apache#17337)

* [broker][admin] Add cmd to remove topic properties

* address comment

* address comment

(cherry picked from commit 7075a5c)
Signed-off-by: Zixuan Liu <nodeces@gmail.com>

* [fix][broker] Fix NPE when updating topic's properties (apache#17352)

Co-authored-by: bjhuxiaohua <bjhuxiaohua@foxmail.com>
(cherry picked from commit f1d1158)

---------

Co-authored-by: Xiaoyu Hou <anonhxygo@gmail.com>
Co-authored-by: Ruguo Yu <jiang7chengzitc@163.com>
Co-authored-by: Flowermin <48741608+Flowermin@users.noreply.github.com>
nodece added a commit to ascentstream/pulsar that referenced this pull request Mar 15, 2024
@nodece @AnonHxy
@yuruguo @Flowermin
[feat][broker] Update and remove topic properties (#4)
888bd2f 
* [broker][admin]Add api for update topic properties (apache#17238)

(cherry picked from commit b21f728)
Signed-off-by: Zixuan Liu <nodeces@gmail.com>

* [broker][admin] Add cmd to remove topic properties (apache#17337)

* [broker][admin] Add cmd to remove topic properties

* address comment

* address comment

(cherry picked from commit 7075a5c)
Signed-off-by: Zixuan Liu <nodeces@gmail.com>

* [fix][broker] Fix NPE when updating topic's properties (apache#17352)

Co-authored-by: bjhuxiaohua <bjhuxiaohua@foxmail.com>
(cherry picked from commit f1d1158)

---------

Co-authored-by: Xiaoyu Hou <anonhxygo@gmail.com>
Co-authored-by: Ruguo Yu <jiang7chengzitc@163.com>
Co-authored-by: Flowermin <48741608+Flowermin@users.noreply.github.com>
nodece added a commit to ascentstream/pulsar that referenced this pull request Mar 15, 2024
@nodece @AnonHxy
@yuruguo @Flowermin
[feat][broker] Update and remove topic properties (#4)
9265ceb 
* [broker][admin]Add api for update topic properties (apache#17238)

(cherry picked from commit b21f728)
Signed-off-by: Zixuan Liu <nodeces@gmail.com>

* [broker][admin] Add cmd to remove topic properties (apache#17337)

* [broker][admin] Add cmd to remove topic properties

* address comment

* address comment

(cherry picked from commit 7075a5c)
Signed-off-by: Zixuan Liu <nodeces@gmail.com>

* [fix][broker] Fix NPE when updating topic's properties (apache#17352)

Co-authored-by: bjhuxiaohua <bjhuxiaohua@foxmail.com>
(cherry picked from commit f1d1158)

---------

Co-authored-by: Xiaoyu Hou <anonhxygo@gmail.com>
Co-authored-by: Ruguo Yu <jiang7chengzitc@163.com>
Co-authored-by: Flowermin <48741608+Flowermin@users.noreply.github.com>
nodece added a commit to nodece/pulsar that referenced this pull request May 11, 2024
@nodece @AnonHxy
@yuruguo @Flowermin
[feat][broker] Update and remove topic properties (#4)
8e3ddeb 
* [broker][admin]Add api for update topic properties (apache#17238)

(cherry picked from commit b21f728)
Signed-off-by: Zixuan Liu <nodeces@gmail.com>

* [broker][admin] Add cmd to remove topic properties (apache#17337)

* [broker][admin] Add cmd to remove topic properties

* address comment

* address comment

(cherry picked from commit 7075a5c)
Signed-off-by: Zixuan Liu <nodeces@gmail.com>

* [fix][broker] Fix NPE when updating topic's properties (apache#17352)

Co-authored-by: bjhuxiaohua <bjhuxiaohua@foxmail.com>
(cherry picked from commit f1d1158)

---------

Co-authored-by: Xiaoyu Hou <anonhxygo@gmail.com>
Co-authored-by: Ruguo Yu <jiang7chengzitc@163.com>
Co-authored-by: Flowermin <48741608+Flowermin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jason918 Jason918 Jason918 approved these changes
@AnonHxy AnonHxy AnonHxy approved these changes
@codelipenghui codelipenghui Awaiting requested review from codelipenghui
@mattisonchao mattisonchao Awaiting requested review from mattisonchao
@Technoboy- Technoboy- Awaiting requested review from Technoboy-

Assignees

@yuruguo yuruguo

Labels

area/admin doc-not-needed Your PR changes do not impact docs type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@yuruguo @liangyepianzhou @Jason918 @AnonHxy