Skip to content

[test][admin]add test case: delete namespace when has partitioned system topic - #17338

Merged
Technoboy- merged 1 commit into
apache:masterfrom
poorbarcode:fix/deleteNamespace
Sep 16, 2022
Merged

[test][admin]add test case: delete namespace when has partitioned system topic#17338
Technoboy- merged 1 commit into
apache:masterfrom
poorbarcode:fix/deleteNamespace

Conversation

@poorbarcode

@poorbarcode poorbarcode commented Aug 29, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Motivation

When a namespace containing partitioned topics is deleted, will throw the topic not found exception.

截屏2022-08-29 22 32 13

(High light) Should use API deletePartitionedTopicAsync to delete partitioned system topic.

Modifications

  • Use cmd-deletePartitionedTopicAsync to delete partitioned system topic.
  • Add tests: delete namespace.

Documentation

  • doc-required

  • doc-not-needed

  • doc

  • doc-complete

@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Aug 29, 2022
@codelipenghui codelipenghui added this to the 2.12.0 milestone Aug 30, 2022
@poorbarcode poorbarcode changed the title [fix][broker]delete namespace fail when has partitioned system topic [fix][admin]delete namespace fail when has partitioned system topic Aug 30, 2022
@dlg99

dlg99 commented Aug 30, 2022

Copy link
Copy Markdown
Contributor

Related PRs, please take a look: #15141
and #17308

@dlg99

dlg99 commented Aug 30, 2022

Copy link
Copy Markdown
Contributor

I think CI failure is fixed by #17339
I'll rebase this PR and let Ci rerun

dlg99
dlg99 reviewed Aug 30, 2022
View reviewed changes

@dlg99 dlg99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it a problem if the topic autocreation disabled? (e.g. see #17308 )
If it was not, maybe namespace deletion (at least the forced one) should disable topic autocreation before attempting the deletion.

@poorbarcode

poorbarcode commented Aug 30, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hi @dlg99

Thanks.

Related PRs, please take a look: #15141 and #17308

let me add some description

#15141 try fix the issue "delete namespace when has non persistent topic".

#17308 try fix the race condition between auto create topic and delete partitioned topic

Was it a problem if the topic autocreation disabled? (e.g. see #17308 )
If it was not, maybe namespace deletion (at least the forced one) should disable topic autocreation before attempting the deletion.

Not. When Auto Create is disabled, everything is fine. #17308 try to fix datastax#112, that is a really difficult problem to solve, I left a comment at #17308

nodece
nodece reviewed Aug 31, 2022
View reviewed changes
Comment thread pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java Outdated
gaozhangmin
gaozhangmin reviewed Aug 31, 2022
View reviewed changes
Comment thread pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java Outdated
gaozhangmin
gaozhangmin requested changes Aug 31, 2022
View reviewed changes
Comment thread pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java Outdated
@poorbarcode

poorbarcode commented Aug 31, 2022

Copy link
Copy Markdown
Contributor Author

/pulsarbot rerun-failure-checks

2 similar comments
@poorbarcode

poorbarcode commented Aug 31, 2022

Copy link
Copy Markdown
Contributor Author

/pulsarbot rerun-failure-checks

@poorbarcode

poorbarcode commented Sep 1, 2022

Copy link
Copy Markdown
Contributor Author

/pulsarbot rerun-failure-checks

@poorbarcode poorbarcode changed the title [test][admin]add test case: delete namespace [test][admin]add test case: delete namespace when has partitioned system topic Sep 15, 2022
@Technoboy-
Technoboy- merged commit bfbe381 into apache:master Sep 16, 2022
codertmy pushed a commit to codertmy/pulsar that referenced this pull request Sep 16, 2022
@poorbarcode tmytangmingyang
[fix][broker]add test case for deleting namespace fail when has parti…
720fa35 
…tioned system topic (apache#17338)
@poorbarcode
poorbarcode deleted the fix/deleteNamespace branch September 17, 2022 02:44
@Technoboy- Technoboy- modified the milestones: 2.12.0, 2.11.0 Oct 14, 2022
liangyepianzhou pushed a commit that referenced this pull request Dec 12, 2022
@poorbarcode @liangyepianzhou
[fix][broker]add test case for deleting namespace fail when has parti…
1d89e0c 
…tioned system topic (#17338)

(cherry picked from commit bfbe381)
liangyepianzhou added a commit that referenced this pull request Dec 12, 2022
@liangyepianzhou
[cherry-pick][branch-2.10] fix test after cherry-pick #17338
d149992
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Jan 10, 2023
@poorbarcode @nicoloboschi
[fix][broker]add test case for deleting namespace fail when has parti…
2d1c7e2 
…tioned system topic (apache#17338)

(cherry picked from commit bfbe381)
(cherry picked from commit 1d89e0c)
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Jan 11, 2023
@poorbarcode @nicoloboschi
[fix][broker]add test case for deleting namespace fail when has parti…
11c0def 
…tioned system topic (apache#17338)

(cherry picked from commit bfbe381)
(cherry picked from commit 1d89e0c)
coderzc pushed a commit that referenced this pull request Feb 28, 2023
@poorbarcode @coderzc
[fix][broker]add test case for deleting namespace fail when has parti…
f1ec5ca 
…tioned system topic (#17338)

(cherry picked from commit bfbe381)
@coderzc coderzc added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Feb 28, 2023
coderzc added a commit to coderzc/pulsar that referenced this pull request Feb 28, 2023
@coderzc
Revert "[fix][broker]add test case for deleting namespace fail when h…
e3b2a15 
…as partitioned system topic (apache#17338)"

This reverts commit f1ec5ca.
coderzc added a commit that referenced this pull request Feb 28, 2023
@coderzc
Revert "[fix][broker]add test case for deleting namespace fail when h…
23c297c 
…as partitioned system topic (#17338)"

This reverts commit f1ec5ca.
@coderzc coderzc added release/2.9.6 and removed cherry-picked/branch-2.9 Archived: 2.9 is end of life release/2.9.5 labels Feb 28, 2023
Annavar-satish pushed a commit to pandio-com/pulsar that referenced this pull request Mar 6, 2023
@poorbarcode ANNAVAR.SATISH
[fix][broker]add test case for deleting namespace fail when has parti…
b4029c5 
…tioned system topic (apache#17338)

(cherry picked from commit bfbe381)
Annavar-satish pushed a commit to pandio-com/pulsar that referenced this pull request Mar 6, 2023
@coderzc ANNAVAR.SATISH
Revert "[fix][broker]add test case for deleting namespace fail when h…
64b9ed8 
…as partitioned system topic (apache#17338)"

This reverts commit f1ec5ca.
@michaeljmarshall

michaeljmarshall commented Jun 27, 2023

Copy link
Copy Markdown
Member

As discussed on the mailing list https://lists.apache.org/thread/w4jzk27qhtosgsz7l9bmhf1t7o9mxjhp, there is no plan to release 2.9.6, so I am going to remove the release/2.9.6 label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dlg99 dlg99 dlg99 left review comments
@eolivelli eolivelli eolivelli left review comments
@Technoboy- Technoboy- Technoboy- approved these changes
@gaozhangmin gaozhangmin gaozhangmin approved these changes
@nodece nodece nodece approved these changes
@congbobo184 congbobo184 congbobo184 approved these changes
@codelipenghui codelipenghui Awaiting requested review from codelipenghui

Assignees

@poorbarcode poorbarcode

Labels

area/test cherry-picked/branch-2.10 cherry-picked/branch-2.11 doc-not-needed Your PR changes do not impact docs release/2.10.3 type/bug The PR fixed a bug or issue reported a bug

Projects

None yet

Milestone

2.11.0

Development

Successfully merging this pull request may close these issues.