[feat][broker]PIP-180 ShadowTopic - Part IV - Add Shadow Replicator - #17371
Merged
Conversation
Contributor
Author
|
/pulsarbot run-failure-checks |
Jason918
requested review from
AnonHxy,
codelipenghui and
eolivelli
and removed request for
codelipenghui and
eolivelli
September 4, 2022 04:18
AnonHxy
reviewed
Sep 6, 2022
Contributor
Author
|
@AnonHxy Addressed comments. PTAL |
AnonHxy
reviewed
Sep 6, 2022
AnonHxy
approved these changes
Sep 7, 2022
Contributor
|
LGTM now |
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
Author
Jason918
added
type/feature
codelipenghui
left a comment
codelipenghui
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just left some minor comments
Contributor
Author
|
@codelipenghui PTAL |
codelipenghui
approved these changes
Sep 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master Issue: #16153
Motivation
Add ShadowReplicator.
Modifications
PersistentTopic#shadowReplicators, most of its management just followsPersistentTopic#replicatorsShadowReplicatorVerifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
None
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-neededInternal implementation.
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)