[fix][cpp] Use weak ptr avoid circular references. - #17481
Merged
Conversation
Contributor
|
Please rebase to master to have some CI fixes. |
shibd
force-pushed
the
fix_multi_timer
branch
from
September 14, 2022 14:17
2070a5f to
b3a54f7
Compare
BewareMyPower
added
component/client-c++
type/bug
BewareMyPower
approved these changes
Sep 21, 2022
RobertIndie
approved these changes
Sep 22, 2022
5 tasks
congbobo184
pushed a commit
that referenced
this pull request
Nov 14, 2022
### Motivation Capturing shared ptr in the timer function will cause a circular reference. ### Modifications - Use weak ptr instead shared ptr. (cherry picked from commit 141981b)
congbobo184
pushed a commit
that referenced
this pull request
Dec 7, 2022
### Motivation Capturing shared ptr in the timer function will cause a circular reference. ### Modifications - Use weak ptr instead shared ptr. (cherry picked from commit 141981b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Capturing shared ptr in the timer function will cause a circular reference.
Modifications
Documentation
doc-not-needed