Skip to content

[improve][admin]namespace CLI set-offload-policy's thresholdBytes support negative and 0 #17502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Technoboy- merged 7 commits into from
Sep 21, 2022
Merged

[improve][admin]namespace CLI set-offload-policy's thresholdBytes support negative and 0 #17502

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
91a89ca
namespace cli set-offload-policy's thresholdBytes support negative and 0
Sep 6, 2022
8f9c335
Merge branch 'master' into set-namespace-offload-policy-threshold-sup…
ethqunzhong Sep 7, 2022
534c5c2
Merge branch 'master' into set-namespace-offload-policy-threshold-sup…
ethqunzhong Sep 7, 2022
24aa20f
Merge branch 'master' into set-namespace-offload-policy-threshold-sup…
ethqunzhong Sep 7, 2022
63983da
Merge branch 'master' into set-namespace-offload-policy-threshold-sup…
ethqunzhong Sep 8, 2022
915d624
Merge branch 'master' into set-namespace-offload-policy-threshold-sup…
ethqunzhong Sep 8, 2022
c96700e
Merge branch 'master' into set-namespace-offload-policy-threshold-sup…
ethqunzhong Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdNamespaces.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2362,8 +2362,7 @@ && maxValueCheck("OffloadAfterElapsed", offloadAfterElapsed, Long.MAX_VALUE)) {
Long offloadAfterThresholdInBytes = OffloadPoliciesImpl.DEFAULT_OFFLOAD_THRESHOLD_IN_BYTES;
if (StringUtils.isNotEmpty(offloadAfterThresholdStr)) {
long offloadAfterThreshold = validateSizeString(offloadAfterThresholdStr);
if (positiveCheck("OffloadAfterThreshold", offloadAfterThreshold)
&& maxValueCheck("OffloadAfterThreshold", offloadAfterThreshold, Long.MAX_VALUE)) {
if (maxValueCheck("OffloadAfterThreshold", offloadAfterThreshold, Long.MAX_VALUE)) {
offloadAfterThresholdInBytes = offloadAfterThreshold;
}
}
Expand Down