Skip to content

[improve][test] Add integration test for broker interceptors - #17515

Merged
Technoboy- merged 6 commits into
apache:masterfrom
andrasbeni:integrationTests-interceptor
Sep 21, 2022
Merged

[improve][test] Add integration test for broker interceptors#17515
Technoboy- merged 6 commits into
apache:masterfrom
andrasbeni:integrationTests-interceptor

Conversation

@andrasbeni

@andrasbeni andrasbeni commented Sep 7, 2022

Copy link
Copy Markdown
Contributor

Running tests at: andrasbeni#2

Master Issue: #17132

Motivation

Increase test coverage of broker interceptor functionality.

Modifications

  • Created broker interceptor LoggingBrokerInterceptor.
  • Created a test that configures the interceptor for the broker and verifies through the broker log that the interceptor's methods are called

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

Added integration tests for broker interceptors

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • doc-not-needed
    This change only affects tests

@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Sep 7, 2022
@andrasbeni

Copy link
Copy Markdown
Contributor Author

/pulsarbot rerun-failure-checks

@andrasbeni

Copy link
Copy Markdown
Contributor Author

/pulsarbot run-failure-checks

@andrasbeni andrasbeni closed this Sep 14, 2022
@andrasbeni andrasbeni reopened this Sep 14, 2022
@andrasbeni

Copy link
Copy Markdown
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@andrasbeni

Copy link
Copy Markdown
Contributor Author

/pulsarbot run-failure-checks

@merlimat

Copy link
Copy Markdown
Contributor

/pulsarbot rerun-failure-checks

@andrasbeni andrasbeni closed this Sep 20, 2022
@andrasbeni andrasbeni reopened this Sep 20, 2022
@codelipenghui codelipenghui added this to the 2.12.0 milestone Sep 20, 2022
@andrasbeni

Copy link
Copy Markdown
Contributor Author

/pulsarbot rerun-failure-checks

@Technoboy-
Technoboy- merged commit bb98333 into apache:master Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants