[ci] Move owasp check into the main workflow - #17568
Merged
Merged
Conversation
lhotari
reviewed
Sep 9, 2022
lhotari
approved these changes
Sep 9, 2022
nicoloboschi
force-pushed
the
ci-move-owasp
branch
from
September 12, 2022 07:11
51292d3 to
8d24d30
Compare
nicoloboschi
force-pushed
the
ci-move-owasp
branch
from
September 12, 2022 11:24
8a80af3 to
2e7db7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently for every pull a new runner is requested to run the Owasp check. If your pull doesn't change a pom.xml file, the workflow exits without doing nothing.
Moving it inside the main workflow will bring these benefits:
Modifications
need_owasp. I thought to usepoms_onlyinitially but it may be misleading since it also check for owasp suppressions files.doc-not-needed