Skip to content

[feat][broker][PIP-195] Implement delayed message index bucket snapshot (create/load) - part2 - #17611

Merged
codelipenghui merged 18 commits into
apache:masterfrom
coderzc:bucket_delayed_message_2
Nov 5, 2022
Merged

[feat][broker][PIP-195] Implement delayed message index bucket snapshot (create/load) - part2#17611
codelipenghui merged 18 commits into
apache:masterfrom
coderzc:bucket_delayed_message_2

Conversation

@coderzc

@coderzc coderzc commented Sep 13, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Master Issue: #16763

Motivation

#16763

Modifications

  • Implement delayed message index bucket
  • Implement delayed message index bucket snapshot (create/load)
  • Reuse and refactor InMemoryDelayedDeliveryTracker
  • Reuse and refactor InMemoryDeliveryTrackerTest
  • Add test for BuketDelayedDeliveryTracker

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

Matching PR in forked repository
PR in forked repository: coderzc#2

@coderzc

coderzc commented Sep 13, 2022

Copy link
Copy Markdown
Member Author

Dependent on #17344 and #17164

@coderzc
coderzc force-pushed the bucket_delayed_message_2 branch from 9e6d420 to 9ba2806 Compare September 13, 2022 09:52
@coderzc
coderzc marked this pull request as draft September 13, 2022 09:54
@coderzc
coderzc force-pushed the bucket_delayed_message_2 branch 2 times, most recently from 91319a7 to 5605657 Compare September 13, 2022 09:58
@coderzc
coderzc marked this pull request as ready for review September 13, 2022 10:03
@coderzc

coderzc commented Sep 14, 2022

Copy link
Copy Markdown
Member Author

@codelipenghui @gaoran10 @Technoboy- PTAL

@codelipenghui codelipenghui added this to the 2.12.0 milestone Sep 14, 2022
@codelipenghui codelipenghui added type/feature The PR added a new feature or issue requested a new feature area/broker labels Sep 14, 2022
@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Sep 14, 2022
@coderzc
coderzc force-pushed the bucket_delayed_message_2 branch 2 times, most recently from 5dc767a to ea0cc42 Compare September 19, 2022 09:08
@coderzc coderzc closed this Sep 20, 2022
@coderzc coderzc reopened this Sep 20, 2022
@coderzc
coderzc force-pushed the bucket_delayed_message_2 branch 2 times, most recently from 582b076 to 9ab3fa1 Compare September 21, 2022 02:19
@coderzc coderzc mentioned this pull request Sep 21, 2022
Merged
5 tasks
@coderzc
coderzc force-pushed the bucket_delayed_message_2 branch from 9ab3fa1 to d19d5d8 Compare October 10, 2022 12:01
@coderzc coderzc changed the title [feat][broker][PIP-195] Implement delayed message index bucket snapshot (create/load/recover) - part2 [feat][broker][PIP-195] Implement delayed message index bucket snapshot (create/load) - part2 Oct 10, 2022
mattisonchao
mattisonchao reviewed Oct 10, 2022
View reviewed changes

@mattisonchao mattisonchao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!!
Left too many comments and questions.

Comment thread pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/Bucket.java Outdated
Comment thread pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/BucketDelayedDeliveryTracker.java Outdated
Comment thread pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/BucketDelayedDeliveryTracker.java Outdated
Comment thread pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/BucketDelayedDeliveryTracker.java Outdated
Comment thread pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/BucketDelayedDeliveryTracker.java Outdated
Comment thread pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/BucketDelayedDeliveryTracker.java Outdated
Comment thread pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/BucketDelayedDeliveryTracker.java Outdated
Comment thread pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/BucketDelayedDeliveryTracker.java Outdated
Comment thread pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/BucketDelayedDeliveryTracker.java Outdated
Comment thread pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/BucketDelayedDeliveryTracker.java Outdated
@mattisonchao

mattisonchao commented Oct 10, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

I will review it again tomorrow(test & logic), thanks for your great work!

@coderzc
coderzc force-pushed the bucket_delayed_message_2 branch from 8e6908a to 4141fa0 Compare October 11, 2022 08:14
@coderzc
coderzc requested a review from mattisonchao October 11, 2022 08:16
@coderzc
coderzc force-pushed the bucket_delayed_message_2 branch 2 times, most recently from 4bd9cbf to 86a76fa Compare October 12, 2022 04:22
mattisonchao
mattisonchao reviewed Oct 12, 2022
View reviewed changes
Comment thread pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/BucketState.java Outdated
Comment thread pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/BucketDelayedDeliveryTracker.java Outdated
Comment thread pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/BucketDelayedDeliveryTracker.java Outdated
Comment thread pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/BucketDelayedDeliveryTracker.java Outdated
Comment thread pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/BucketDelayedDeliveryTracker.java Outdated
@coderzc
coderzc requested a review from mattisonchao October 13, 2022 10:45
@coderzc
coderzc force-pushed the bucket_delayed_message_2 branch 4 times, most recently from f745c40 to 0b3b897 Compare November 4, 2022 05:51
@coderzc
coderzc force-pushed the bucket_delayed_message_2 branch 3 times, most recently from c925582 to b311c6d Compare November 4, 2022 07:17
@coderzc
coderzc force-pushed the bucket_delayed_message_2 branch from b311c6d to 8405d13 Compare November 4, 2022 07:20
@coderzc

coderzc commented Nov 4, 2022

Copy link
Copy Markdown
Member Author

/pulsarbot run-failure-checks

@codelipenghui
codelipenghui merged commit e6f4aae into apache:master Nov 5, 2022
@dao-jun dao-jun mentioned this pull request Jun 23, 2026
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Technoboy- Technoboy- Technoboy- left review comments
@gaoran10 gaoran10 gaoran10 left review comments
@mattisonchao mattisonchao mattisonchao approved these changes
@codelipenghui codelipenghui codelipenghui approved these changes
@poorbarcode poorbarcode poorbarcode approved these changes

Assignees

@coderzc coderzc

Labels

area/broker doc-not-needed Your PR changes do not impact docs ready-to-test type/feature The PR added a new feature or issue requested a new feature

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@coderzc @mattisonchao @codecov-commenter @Technoboy- @codelipenghui @gaoran10 @poorbarcode