Skip to content

[fix][cpp] Revert OpenSSL version in rpm and deb package - #17612

Closed
RobertIndie wants to merge 1 commit into
apache:masterfrom
RobertIndie:fix-openssl
Closed

[fix][cpp] Revert OpenSSL version in rpm and deb package#17612
RobertIndie wants to merge 1 commit into
apache:masterfrom
RobertIndie:fix-openssl

Conversation

@RobertIndie

Copy link
Copy Markdown
Member

Motivation

See #17538 (comment)
This issue has blocked the master branch. Revert the OepnSSL version in rpm and deb package to unblock the master until we find the root cause and give a fix.

Modifications

  • Revert OpenSSL version from 111n to 110j in rpm and deb package.

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@RobertIndie RobertIndie added type/bug The PR fixed a bug or issue reported a bug component/client-c++ labels Sep 13, 2022
@RobertIndie RobertIndie self-assigned this Sep 13, 2022

@BewareMyPower BewareMyPower left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I found the root cause is the ABI compatibility change of libopenssl and the link order issue in debian:9 image.
At the moment, I'm verifying the change locally currently and going to push a new PR to replace this revert soon.

@lhotari

lhotari commented Sep 13, 2022

Copy link
Copy Markdown
Member

Actually I found the root cause is the ABI compatibility change of libopenssl and the link order issue in debian:9 image. At the moment, I'm verifying the change locally currently and going to push a new PR to replace this revert soon.

It's possible to get the libcurl compilation to pass, but I'm just wondering what the purpose of it is in the first place.
The solution in the Dockerfile has a mistake since it's not adding /usr/local/ssl/lib to ld.so.conf . This would be a way to achieve that:

echo /usr/local/ssl/lib >> /etc/ld.so.conf.d/ssl.conf && ldconfig -v

With this change, the compilation would pass, but I'm not sure if it would be the correct solution.

@lhotari

lhotari commented Sep 13, 2022

Copy link
Copy Markdown
Member

I made another attempt in #17613 which fixes the invalid linking configuration.

@lhotari

lhotari commented Sep 13, 2022

Copy link
Copy Markdown
Member

Replaced with #17614

@lhotari lhotari closed this Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/bug The PR fixed a bug or issue reported a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants