Skip to content

[fix][broker] Unregister topic policy listener if managed ledger close failed - #17652

Merged
Technoboy- merged 1 commit into
apache:masterfrom
codelipenghui:penghui/unregister_topic_policy_listener
Sep 15, 2022
Merged

[fix][broker] Unregister topic policy listener if managed ledger close failed#17652
Technoboy- merged 1 commit into
apache:masterfrom
codelipenghui:penghui/unregister_topic_policy_listener

Conversation

@codelipenghui

Copy link
Copy Markdown
Contributor

Motivation

After the topic closed failed due to metadata BadVersionException, we should unregister the topic policy listener.
Otherwise, the topic policy listener will get leaked.

image

@github-actions

Copy link
Copy Markdown

@codelipenghui Please provide a correct documentation label for your PR.
Instructions see Pulsar Documentation Label Guide.

@codelipenghui codelipenghui added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Sep 15, 2022
@github-actions github-actions Bot added doc-label-missing and removed doc-not-needed Your PR changes do not impact docs labels Sep 15, 2022
@codelipenghui codelipenghui added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Sep 15, 2022
@github-actions github-actions Bot added doc-label-missing and removed doc-not-needed Your PR changes do not impact docs labels Sep 15, 2022
@Technoboy- Technoboy- added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Sep 15, 2022
@github-actions github-actions Bot added doc-label-missing and removed doc-not-needed Your PR changes do not impact docs labels Sep 15, 2022

@mattisonchao mattisonchao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@Technoboy-
Technoboy- merged commit dc54997 into apache:master Sep 15, 2022
@Technoboy- Technoboy- modified the milestones: 2.12.0, 2.11.0 Sep 15, 2022
@codelipenghui
codelipenghui deleted the penghui/unregister_topic_policy_listener branch September 15, 2022 03:33
@Jason918

Copy link
Copy Markdown
Contributor

Covered by #17736 in branch-2.10

congbobo184 pushed a commit that referenced this pull request Nov 9, 2022
@congbobo184 congbobo184 added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Nov 9, 2022
congbobo184 pushed a commit that referenced this pull request Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants