Skip to content

[improve][cli] Pulsar shell: allow to create a new config (--file) with a relative path - #17675

Merged
eolivelli merged 3 commits into
apache:masterfrom
nicoloboschi:pulsar-shell-f-rel
Sep 16, 2022
Merged

[improve][cli] Pulsar shell: allow to create a new config (--file) with a relative path#17675
eolivelli merged 3 commits into
apache:masterfrom
nicoloboschi:pulsar-shell-f-rel

Conversation

@nicoloboschi

Copy link
Copy Markdown
Contributor

Motivation

After #17648 it's no more possible to create/update configs from a relative path (at least is not relative to the current directory but from the Pulsar home dir which is not useful)

Modifications

  • Added current dir as system property. Pulsar shell uses it for autocompletion and for resolving the file passed with --file
  • doc-not-needed

@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Sep 15, 2022

@eolivelli eolivelli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eolivelli
eolivelli merged commit d7c09be into apache:master Sep 16, 2022
@nicoloboschi nicoloboschi added this to the 2.12.0 milestone Sep 16, 2022
nicoloboschi added a commit that referenced this pull request Sep 16, 2022
…th a relative path (#17675)

* [improve][cli] Pulsar shell: allow to create a new config (--file) with a relative path

* win

* checkstlye

(cherry picked from commit d7c09be)
nicoloboschi added a commit to datastax/pulsar that referenced this pull request Sep 16, 2022
…th a relative path (apache#17675)

* [improve][cli] Pulsar shell: allow to create a new config (--file) with a relative path

* win

* checkstlye

(cherry picked from commit d7c09be)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants