[improve][test] remove powermock-reflect dependency - #17696
Merged
Conversation
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
nicoloboschi
approved these changes
Sep 17, 2022
nicoloboschi
left a comment
nicoloboschi
left a comment
Contributor
There was a problem hiding this comment.
LGTM but tbh it's a very long pull 👀
hezhangjian
approved these changes
Sep 17, 2022
Member
Author
|
Thanks for your reviews! Could You help with merging this patch? @shoothzj @nicoloboschi
As long as we use squash and merge😉 We should try to prevent reintroduce the library in further development randomly. And perhaps it's time to convert the "community" page to a contributor guide, like https://inlong.apache.org/community/how-to-contribute. |
BewareMyPower
added a commit
to BewareMyPower/kop
that referenced
this pull request
Feb 22, 2023
### Motivation apache/pulsar#17696 removes the `powermock-reflect` dependency, which leads to a compilation error in KoP. ### Modifications Upgrade the Pulsar dependency to 2.11.0.0-rc5. Then replace `Whitebox.invokeMethod` with `MethodUtils.invokeMethod`.
3 tasks
BewareMyPower
added a commit
to BewareMyPower/kop
that referenced
this pull request
Feb 22, 2023
### Motivation apache/pulsar#17696 removes the `powermock-reflect` dependency, which leads to a compilation error in KoP. ### Modifications Upgrade the Pulsar dependency to 2.11.0.0-rc5. Then replace `Whitebox.invokeMethod` with `MethodUtils.invokeMethod`. It also fixes the bug that null values are not handled well for non-batched messages. This bug was exposed because of [PIP-189](apache/pulsar#16605). ### TODO Migrate the bug fix for non-batched messages to branch-2.10.x and branch-2.9.x.
Demogorgon314
pushed a commit
to streamnative/kop
that referenced
this pull request
Feb 22, 2023
### Motivation apache/pulsar#17696 removes the `powermock-reflect` dependency, which leads to a compilation error in KoP. ### Modifications Upgrade the Pulsar dependency to 2.11.0.0-rc5. Then replace `Whitebox.invokeMethod` with `MethodUtils.invokeMethod`. It also fixes the bug that null values are not handled well for non-batched messages. This bug was exposed because of [PIP-189](apache/pulsar#16605).
Demogorgon314
pushed a commit
to streamnative/kop
that referenced
this pull request
Feb 22, 2023
### Motivation apache/pulsar#17696 removes the `powermock-reflect` dependency, which leads to a compilation error in KoP. ### Modifications Upgrade the Pulsar dependency to 2.11.0.0-rc5. Then replace `Whitebox.invokeMethod` with `MethodUtils.invokeMethod`. It also fixes the bug that null values are not handled well for non-batched messages. This bug was exposed because of [PIP-189](apache/pulsar#16605). (cherry picked from commit 88fe870)
eolivelli
pushed a commit
to eolivelli/kop
that referenced
this pull request
Feb 28, 2023
### Motivation apache/pulsar#17696 removes the `powermock-reflect` dependency, which leads to a compilation error in KoP. ### Modifications Upgrade the Pulsar dependency to 2.11.0.0-rc5. Then replace `Whitebox.invokeMethod` with `MethodUtils.invokeMethod`. It also fixes the bug that null values are not handled well for non-batched messages. This bug was exposed because of [PIP-189](apache/pulsar#16605).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #16912.
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)