[improve][txn]PIP-160 make txn components supports buffered writer metrics - #17701
Merged
Conversation
poorbarcode
force-pushed
the
pip/160-18
branch
2 times, most recently
from
September 17, 2022 08:41
2ca47e0 to
398a6e7
Compare
Contributor
Author
|
This PR should to merge the following branches:
|
poorbarcode
force-pushed
the
pip/160-18
branch
3 times, most recently
from
September 19, 2022 15:42
d20eba4 to
355212b
Compare
congbobo184
requested review from
codelipenghui,
congbobo184,
gaoran10 and
liangyepianzhou
September 20, 2022 02:16
congbobo184
approved these changes
Sep 20, 2022
Contributor
Author
|
/pulsarbot rerun-failure-checks |
poorbarcode
force-pushed
the
pip/160-18
branch
from
September 23, 2022 02:09
7ff2165 to
4fd5fa1
Compare
1 task
congbobo184
pushed a commit
that referenced
this pull request
Nov 16, 2022
Fixes: #17921 <strong>Note</strong>: This patch will change metrics names `s_bufferedwriter_batch_record_count` and `s_bufferedwriter_batch_oldest_record_delay_time_second`. These two names were first used in this PR #17701, and PR #17701 hasn't cherry-picked any branches yet, so this change will not cause any breaking changes. ### Motivation https://github.com/poorbarcode/pulsar/actions/runs/3156649582/jobs/5136584463 https://github.com/apache/pulsar/actions/runs/3156649597/jobs/5136596447 #### Problem-1 If the `Prometheus-Colloctor` which typed `Counter` is named 'xxx_count', then the output `metrics-api` will be named 'xxx_count_count'. `TxnLogBufferedWriterMetricsStats` hits this error. https://github.com/apache/pulsar/blob/fb7307d8f4998e42b18df3a4599fd7ec34cb04a9/pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/TxnLogBufferedWriterMetricsStats.java#L105-L106 ---- #### Problem-2 `PrometheusMetricsTest` defines the standard metrics name(see code below): ``` ["_sum", "_bucket", "_count", "_total", "_created"] ``` But the standard Prometheus name has three others( see: https://github.com/prometheus/client_java/blob/c28b901225e35e7c1df0eacae8b58fdfbb390162/simpleclient/src/main/java/io/prometheus/client/Collector.java#L152-L186 ): ``` ["_info", "_gsum", "_gcount"] ``` https://github.com/apache/pulsar/blob/fb7307d8f4998e42b18df3a4599fd7ec34cb04a9/pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/PrometheusMetricsTest.java#L834-L861 ---- ### Modifications - Make `PrometheusMetricsTest` run with transaction feature - Make txn metrics name conforms to the rule. see: https://prometheus.io/docs/practices/naming/ - Make `PrometheusMetricsTest` support all suffix of prometheus metrics name ### Documentation - [x] `doc-not-needed` (Please explain why) ### Matching PR in forked repository PR in forked repository: - poorbarcode#19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master Issue: #15370
Modifications
MLTransactionMetadataStoreProvider&MLPendingAckStoreProvidersupport buffered writer metrics.TxnLogBufferedWriterwithout parametermetrics.DisabledTxnLogBufferedWriterMetricsStatsimplementation.if (metrics != null). The motivation see:MLTransactionMetadataStoreProvider&MLPendingAckStoreProvider.Documentation
doc-requireddoc-not-neededdocdoc-completeMatching PR in forked repository
PR in forked repository: