[feat][broker][PIP-195] Support internal cursor properties - part4 - #17712
Merged
codelipenghui merged 5 commits intoDec 19, 2022
Merged
Conversation
coderzc
force-pushed
the
support_internal_cursor_properties
branch
2 times, most recently
from
September 19, 2022 04:57
1b66fbd to
a010aa7
Compare
Member
|
the tests failed in Broker Group 3 because of OOM, I filed #17714 . It's most likely not caused by the changes in this PR. |
coderzc
force-pushed
the
support_internal_cursor_properties
branch
from
September 21, 2022 02:20
a010aa7 to
5f60f6d
Compare
|
The pr had no activity for 30 days, mark with Stale label. |
Member
Author
codelipenghui
requested review from
Technoboy-,
codelipenghui,
eolivelli,
mattisonchao and
nicoloboschi
November 4, 2022 02:39
mattisonchao
reviewed
Nov 7, 2022
mattisonchao
reviewed
Nov 7, 2022
mattisonchao
approved these changes
Nov 7, 2022
mattisonchao
left a comment
mattisonchao
left a comment
Member
There was a problem hiding this comment.
It appears to have a minor compatibility issue - if the user has previously used a format like CURSOR_INTERNAL_PROPERTY_PREFIX in cursor properties. I think it's a small probability event though.
Codecov Report
@@ Coverage Diff @@
## master #17712 +/- ##
============================================
+ Coverage 47.23% 47.91% +0.68%
+ Complexity 10430 9349 -1081
============================================
Files 692 613 -79
Lines 67766 58391 -9375
Branches 7260 6087 -1173
============================================
- Hits 32009 27978 -4031
+ Misses 32192 27379 -4813
+ Partials 3565 3034 -531
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
Author
coderzc
added
the
type/enhancement
codelipenghui
approved these changes
Dec 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master Issue: #16763
Motivation
Now, the cursor properties support overall update and modifying a single value concurrently by #17164, but
setCursorPropertieswill all key-value is removed before update properties, this will cause internal property loss, so use a special prefix to prevent internal properties.More context see: #17164 (comment), #17164 (comment), #17164 (comment)
Modifications
Use a special prefix to prevent internal properties.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)
Matching PR in forked repository
PR in forked repository: coderzc#4