[fix][tests] Fix resource leak in tests. Call cleanup before setup - #17743
Merged
Conversation
lhotari
requested review from
Technoboy-,
codelipenghui,
mattisonchao and
nicoloboschi
September 20, 2022 12:03
lhotari
force-pushed
the
lh-fix-resourceleak-in-tests
branch
from
September 20, 2022 12:36
23aab00 to
4896661
Compare
lhotari
force-pushed
the
lh-fix-resourceleak-in-tests
branch
from
September 20, 2022 12:57
4896661 to
3f034cf
Compare
Technoboy-
previously approved these changes
Sep 20, 2022
lhotari
marked this pull request as draft
September 20, 2022 13:51
lhotari
force-pushed
the
lh-fix-resourceleak-in-tests
branch
from
September 20, 2022 15:56
3f034cf to
60968e1
Compare
lhotari
marked this pull request as ready for review
September 20, 2022 15:57
lhotari
marked this pull request as draft
September 20, 2022 15:57
lhotari
force-pushed
the
lh-fix-resourceleak-in-tests
branch
from
September 20, 2022 15:59
60968e1 to
13bdf51
Compare
- when setup is called explicitly, cleanup should be issued before it
- remove unnecessary "resetConfig" method calls
- resetConfig gets called as part of internalCleanup
- when resetConfig is in cleanup, it's possible to override config before calling setup
- this allows using setup & cleanup methods instead of using
error prone internalSetup and internalCleanup methods which might leave something behind
lhotari
force-pushed
the
lh-fix-resourceleak-in-tests
branch
from
September 20, 2022 20:19
13bdf51 to
486c670
Compare
lhotari
marked this pull request as ready for review
September 21, 2022 05:09
Member
Author
|
@Technoboy- this is now ready for review. Please review |
Member
Author
|
/pulsarbot rerun-failure-checks |
nicoloboschi
approved these changes
Sep 21, 2022
nicoloboschi
left a comment
nicoloboschi
left a comment
Contributor
There was a problem hiding this comment.
Nice work! @lhotari
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17714
Motivation
There are a few resource leaks in tests where setup (or internalSetup) is called explicitly without first calling cleanup.
This causes a thread and memory leak in tests which slows down test execution.
Modifications
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)
Matching PR in forked repository
PR in forked repository: lhotari#88