[improve][CI] Don't run CI when PR is in draft status or isn't mergeable - #17749
Merged
merlimat merged 1 commit intoSep 20, 2022
Merged
Conversation
lhotari
force-pushed
the
lh-block-ci-when-draft-or-not-mergeable
branch
from
September 20, 2022 16:29
18fbb78 to
641d2ad
Compare
nicoloboschi
approved these changes
Sep 20, 2022
michaeljmarshall
approved these changes
Sep 20, 2022
michaeljmarshall
left a comment
michaeljmarshall
left a comment
Member
There was a problem hiding this comment.
LGTM. Once we get the CI stable, it'd be good to have a document describing when to expect tests to run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Pulsar CI shouldn't run builds for PRs which are in draft status or aren't mergeable.
Modifications
Add additional checks to check draft status and mergeable status.
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)
Matching PR in forked repository
PR in forked repository: lhotari#89