[improve][cli] Add proxyServiceUrl / proxyProtocol parsing from conf file to pulsar-client CLI - #17932
Merged
lhotari merged 1 commit intoNov 5, 2022
Conversation
lhotari
force-pushed
the
lh-add-proxyServiceUrl-proxyProtocol-parsing-from-properties
branch
from
October 4, 2022 16:20
d923143 to
ff71d89
Compare
|
The pr had no activity for 30 days, mark with Stale label. |
…file to pulsar-client CLI
lhotari
force-pushed
the
lh-add-proxyServiceUrl-proxyProtocol-parsing-from-properties
branch
from
November 4, 2022 19:07
ff71d89 to
d9885c2
Compare
michaeljmarshall
approved these changes
Nov 4, 2022
Member
Author
|
/pulsarbot rerun-failure-checks |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17932 +/- ##
============================================
+ Coverage 40.29% 47.10% +6.81%
- Complexity 8685 10331 +1646
============================================
Files 687 687
Lines 67441 67437 -4
Branches 7225 7226 +1
============================================
+ Hits 27175 31768 +4593
+ Misses 37257 32090 -5167
- Partials 3009 3579 +570
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#17862 added support for pulsar-perf CLI tools (with #17930 to fix some gaps).
It would be consistent to add support for specifying proxyServiceUrl & proxyProtocol in the configuration file also for pulsar-client CLI tool.
Modifications
Add proxyServiceUrl / proxyProtocol parsing from conf file to pulsar-client CLI.
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: lhotari#95