[fix][broker] Fix getPositionAfterN infinite loop.

[Technoboy-]

Fixes #17967

Master Issue: #17967

Motivation

The root cause is here(line-3365) :

pulsar/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java

Lines 3364 to 3366 in 08f5766

	Long lid = ledgers.ceilingKey(currentLedgerId + 1);
	currentLedgerId = lid != null ? lid : (ledgers.lastKey() + 1);
	currentEntryId = 0;

The currentLedgerId should be :

currentLedgerId = lid != null ? lid : (ledgers.lastKey());

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository: https://github.com/Technoboy-/pulsar/pull/9

[codelipenghui]

Great catch!

Is it able to add an unit test?

[Technoboy-]

Great catch!

Is it able to add an unit test?

We already have the test testGetPositionAfterN

[codelipenghui]

We already have the test testGetPositionAfterN

@Technoboy- So why did the test get passed before? I think the test can't cover the case that introduces the infinite loop?

[Technoboy-]

We already have the test testGetPositionAfterN

@Technoboy- So why did the test get passed before? I think the test can't cover the case that introduces the infinite loop?

Ah, yes, right. Sorry for this. I have added the test.

[codelipenghui]

@Technoboy- Please check the failed test

[Technoboy-]

@Technoboy- Please check the failed test

Yes, I have fixed by #17993

[codecov-commenter]

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 45.78%. Comparing base (6c65ca0) to head (bac6889).
⚠️ Report is 3530 commits behind head on master.

Files with missing lines	Patch %	Lines
...che/bookkeeper/mledger/impl/ManagedLedgerImpl.java	80.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             master   #17971       +/-   ##
=============================================
+ Coverage     34.91%   45.78%   +10.87%     
- Complexity     5707    17561    +11854     
=============================================
  Files           607     1573      +966     
  Lines         53396   128213    +74817     
  Branches       5712    14100     +8388     
=============================================
+ Hits          18644    58708    +40064     
- Misses        32119    63406    +31287     
- Partials       2633     6099     +3466     

Flag	Coverage Δ
unittests	45.78% <80.00%> (+10.87%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...che/bookkeeper/mledger/impl/ManagedLedgerImpl.java	71.29% <80.00%> (ø)

... and 1116 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Jason918]

LGTM