[improve][client] Support MAX_ACK_GROUP_SIZE configurable - #18107
Merged
RobertIndie merged 4 commits intoOct 21, 2022
Conversation
RobertIndie
requested changes
Oct 19, 2022
Member
|
Please add some tests to verify the PR. |
Contributor
Author
OK , I will fix |
lordcheng10
force-pushed
the
support_MAX_ACK_GROUP_SIZE_config
branch
from
October 19, 2022 12:07
6540bd4 to
094121f
Compare
Contributor
Author
Fixed.PTAL,thanks!@RobertIndie |
Contributor
Author
|
@eolivelli @RobertIndie @AnonHxy @Jason918 @HQebupt PTAL,thanks! |
AnonHxy
reviewed
Oct 19, 2022
lordcheng10
requested review from
AnonHxy and
RobertIndie
and removed request for
AnonHxy and
RobertIndie
October 20, 2022 02:01
RobertIndie
reviewed
Oct 20, 2022
lordcheng10
force-pushed
the
support_MAX_ACK_GROUP_SIZE_config
branch
from
October 20, 2022 03:54
ce5215a to
9cd92bc
Compare
RobertIndie
reviewed
Oct 20, 2022
RobertIndie
approved these changes
Oct 20, 2022
Contributor
Author
|
/pulsarbot run-failure-checks |
AnonHxy
approved these changes
Oct 20, 2022
aloyszhang
approved these changes
Oct 20, 2022
Contributor
Author
|
CI all passed: lordcheng10#33 |
Contributor
Author
|
/pulsarbot run-failure-checks |
1 similar comment
Contributor
Author
|
/pulsarbot run-failure-checks |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #18107 +/- ##
=============================================
+ Coverage 34.91% 45.74% +10.82%
- Complexity 5707 17568 +11861
=============================================
Files 607 1574 +967
Lines 53396 128526 +75130
Branches 5712 14149 +8437
=============================================
+ Hits 18644 58789 +40145
- Misses 32119 63658 +31539
- Partials 2633 6079 +3446
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Technoboy-
pushed a commit
that referenced
this pull request
Feb 8, 2023
The current MAX_ACK_GROUP_SIZE is fixed at 1000, increase the configuration acknowledgementsGroupSize, support MAX_ACK_GROUP_SIZE configurable: https://github.com/apache/pulsar/blob/afcdbf0e2b5fb905e1f82f0220436f8f9ec0c742/pulsar-client/src/main/java/org/apache/pulsar/client/impl/PersistentAcknowledgmentsGroupingTracker.java#L63-L64 1.Add configuration acknowledgementsGroupSize；
Contributor
|
#18345 relies on this, so cherry-picked to branch-2.11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The current MAX_ACK_GROUP_SIZE is fixed at 1000, increase the configuration acknowledgementsGroupSize, support MAX_ACK_GROUP_SIZE configurable:
pulsar/pulsar-client/src/main/java/org/apache/pulsar/client/impl/PersistentAcknowledgmentsGroupingTracker.java
Lines 63 to 64 in afcdbf0
Modifications
1.Add configuration acknowledgementsGroupSize；
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: lordcheng10#33