Skip to content

[fix][function] Fix invalid metric type "gauge " - #18129

Merged
Technoboy- merged 1 commit into
apache:masterfrom
coderzc:fix_metrics
Oct 24, 2022
Merged

[fix][function] Fix invalid metric type "gauge "#18129
Technoboy- merged 1 commit into
apache:masterfrom
coderzc:fix_metrics

Conversation

@coderzc

@coderzc coderzc commented Oct 20, 2022

Copy link
Copy Markdown
Member

Motivation

Prometheus load metrics error.
image

curl -s 'http://localhost:8080/metrics/'

image

This bug introduce from #15558

Modifications

Remove the space behind the metric type.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Oct 20, 2022
@coderzc coderzc changed the title [fix][broker] Fix invalid metric type "gauge " [fix][broker][functions-worker] Fix invalid metric type "gauge " Oct 20, 2022
@Technoboy- Technoboy- added this to the 2.12.0 milestone Oct 20, 2022
@Technoboy- Technoboy- added type/bug The PR fixed a bug or issue reported a bug area/broker ready-to-test labels Oct 20, 2022
@Technoboy- Technoboy- closed this Oct 20, 2022
@Technoboy- Technoboy- reopened this Oct 20, 2022
@Technoboy- Technoboy- changed the title [fix][broker][functions-worker] Fix invalid metric type "gauge " [fix][function] Fix invalid metric type "gauge " Oct 20, 2022
@codecov-commenter

codecov-commenter commented Oct 20, 2022

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.58%. Comparing base (6c65ca0) to head (55dbe86).
⚠️ Report is 3532 commits behind head on master.

Files with missing lines Patch % Lines
...he/pulsar/functions/worker/WorkerStatsManager.java 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #18129       +/-   ##
=============================================
+ Coverage     34.91%   46.58%   +11.66%     
- Complexity     5707    17884    +12177     
=============================================
  Files           607     1574      +967     
  Lines         53396   128474    +75078     
  Branches       5712    14134     +8422     
=============================================
+ Hits          18644    59848    +41204     
- Misses        32119    62426    +30307     
- Partials       2633     6200     +3567     
Flag Coverage Δ
unittests 46.58% <0.00%> (+11.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...he/pulsar/functions/worker/WorkerStatsManager.java 1.14% <0.00%> (ø)

... and 1151 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coderzc

coderzc commented Oct 20, 2022

Copy link
Copy Markdown
Member Author

@Technoboy- Also need to cherry-pick 2.9.x.

@Technoboy-
Technoboy- merged commit 39270f0 into apache:master Oct 24, 2022
congbobo184 pushed a commit that referenced this pull request Nov 9, 2022
@congbobo184 congbobo184 added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Nov 9, 2022
congbobo184 pushed a commit that referenced this pull request Nov 26, 2022
liangyepianzhou pushed a commit that referenced this pull request Dec 14, 2022
@asafm

asafm commented Dec 19, 2022

Copy link
Copy Markdown
Contributor

Oh, man. Who would have thought this would be an issue? We probably need an e2e test using real Prometheus docker on this. Thanks for the fix @coderzc .

@marksilcox CC

nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Jan 10, 2023
(cherry picked from commit 39270f0)
(cherry picked from commit c5d4355)
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Jan 11, 2023
(cherry picked from commit 39270f0)
(cherry picked from commit c5d4355)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants