Revert "Handle unknown runtime exception while reading entries (#2993)"#18280
Closed
mattisonchao wants to merge 1 commit into
Closed
Revert "Handle unknown runtime exception while reading entries (#2993)"#18280mattisonchao wants to merge 1 commit into
mattisonchao wants to merge 1 commit into
Conversation
This reverts commit 2c8c288
mattisonchao
requested review from
eolivelli and
rdhabalia
and removed request for
rdhabalia
November 1, 2022 09:44
mattisonchao
commented
Nov 1, 2022
| try { | ||
| asyncReadEntry0(lh, position, callback, ctx); | ||
| } catch (Throwable t) { | ||
| log.warn("failed to read entries for {}-{}", lh.getId(), position, t); |
Member
Author
There was a problem hiding this comment.
If callback.readEntryComplete(cachedEntry, ctx); throw any exception(line 226), the exception will also be catched by here, and invoke the callback.readEntryFailed(createManagedLedgerException(t), ctx);.
This means that in some cases we may call both methods, which is a risk to some recycled objects or other states.
Member
Author
There was a problem hiding this comment.
And we shouldn't expire the cache for callback exceptions.
mattisonchao
requested review from
Technoboy-,
codelipenghui,
lhotari,
merlimat and
rdhabalia
November 1, 2022 09:51
|
@mattisonchao Please add the following content to your PR description and select a checkbox: |
mattisonchao
added
doc-not-needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This revert commit 2c8c288
Fixes #16907
Motivation
I think the problem described in #2993 is already solved by #2995, we don't need this workaround fix anymore.
Also, this workaround fix will introduce another problem and I will add a comment to the code.
Modifications
Verifying this change
Make sure that the change passes the CI checks.
doc-not-needed