[fix][broker] In the trimDeletedEntries method, release the removed entry - #18305
Merged
Conversation
Contributor
Author
|
@codelipenghui @Jason918 PTAL,thanks! |
Contributor
Author
|
/pulsarbot run-failure-checks |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18305 +/- ##
============================================
- Coverage 38.97% 38.54% -0.44%
- Complexity 8311 8868 +557
============================================
Files 683 747 +64
Lines 67325 72197 +4872
Branches 7217 7754 +537
============================================
+ Hits 26239 27825 +1586
- Misses 38079 41261 +3182
- Partials 3007 3111 +104
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
Author
Contributor
Author
|
@Technoboy- PTAL,thanks! |
coderzc
approved these changes
Nov 3, 2022
Contributor
Author
|
/pulsarbot run-failure-checks |
2 similar comments
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
Author
|
/pulsarbot run-failure-checks |
Member
|
aloyszhang
pushed a commit
to aloyszhang/pulsar
that referenced
this pull request
Nov 30, 2022
…ntry (apache#18305) (merge request !161) Squash merge branch 'release-2.8.1.4-fix_mem_leak' into 'release-2.8.1.4' Fixes #<xyz> ### Motivation [fix][broker] In the trimDeletedEntries method, release the removed entry (apache#18305)
aloyszhang
pushed a commit
to aloyszhang/pulsar
that referenced
this pull request
Jan 9, 2023
…ntry (apache#18305) (merge request !161) Squash merge branch 'release-2.8.1.4-fix_mem_leak' into 'release-2.8.1.4' Fixes #<xyz> ### Motivation [fix][broker] In the trimDeletedEntries method, release the removed entry (apache#18305)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 10, 2023
…ntry (apache#18305) (cherry picked from commit 79a3f85) (cherry picked from commit 4eb93ec)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 11, 2023
…ntry (apache#18305) (cherry picked from commit 79a3f85) (cherry picked from commit 4eb93ec)
Technoboy-
pushed a commit
that referenced
this pull request
Feb 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In the trimDeletedEntries method, the removed entry is not released:
pulsar/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
Lines 3307 to 3310 in 2e878e8
pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java
Lines 582 to 585 in 2e878e8
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: lordcheng10#38